Do not consider empty jsx expressions semantically important children #41166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
sandersn
approved these changes
Oct 19, 2020
| @@ -0,0 +1,19 @@ | |||
| // @jsx: react,react-jsx,react-jsxdev | |||
There was a problem hiding this comment.
are react/react-jsx/react-jsxdev meaningfully different for this change? Or does this just help coverage some other way?
It was harder to read the baselines since they were in triplicate.
There was a problem hiding this comment.
Yep! The JS output is different for each! In react createElement is used, with arrays or singleton children. In react-jsx, the jsx and jsxs ctors are toggled between based on if the child is detected as singleton or not (in addition to array/no array in the actual argument). In react-jsxdev, the isStatic parameter passed to the ctor is changed based on weather a singleton child is detected or not. So there's meaningful output to check for all 3!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41125
This also extracts some repeated logic into a helper.