Shebang #4120
Merged
Shebang #4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| //// [shebang.js] | ||
| #!/usr/bin/env node |
There was a problem hiding this comment.
So, does node ignore shebangs?
There was a problem hiding this comment.
Can you add tests where the # isn't on the first position. Thanks!
|
Looks pretty good to me. With a couple of changes this should be good to go in. I'd like @ahejlsberg to weigh in if we want to go ahead with them. My only concern is how this affects our ability to do something like add support for |
|
Done:
|
| /** Optionally, get the shebang */ | ||
| export function getShebang(text: string): string { | ||
| return shebangTriviaRegex.test(text) | ||
| ? shebangTriviaRegex.exec(text)[0] |
|
@mhegazy You ok with this? |
| @@ -528,6 +538,20 @@ namespace ts { | |||
| return pos; | |||
| } | |||
|
|
|||
| let shebangTriviaRegex = /^#!.*/; | |||
|
Done (as an amendment on the CR commit):
|
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2749
Appreciate a review by @CyrusNajmabadi : Emit ended up as a strategic call similar to detached comments
Also wrote : http://basarat.gitbooks.io/typescript/content/docs/compiler/contributing.html since I was in the area 🌹