Skip to content

When creating synthetic default symbol set parent as module symbol #41282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

sheetalkamat
Copy link
Member

Fixes #40684

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the structure of non-synthetic default export symbols, right? As long as that’s the case, makes sense

Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, this is probably OK, so long as nothing's expecting symbol.parent.members or symbol.parent.exports actually contains symbol... The real parent should probably be the anonymousSymbol defined below, since that's the symbol whose (associated type's) members table actually contains this symbol, at least that's what I'd have thought.

@sheetalkamat
Copy link
Member Author

@weswigham this is mainly so that this synthetic default has parent similar to what happens when you have written default declaration in the file. Without this it would be hard to figure out moduleSymbol from this synthetic default

@sheetalkamat sheetalkamat merged commit e17d95d into master Oct 28, 2020
@sheetalkamat sheetalkamat deleted the symbolParent branch October 28, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug Failure. Symbol parent was undefined.
4 participants