Don’t create missing nodes for identifiers that would be valid in a newer script target #42520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
approved these changes
Jan 27, 2021
rbuckton
approved these changes
Jan 29, 2021
| if (isIdentifier) { | ||
| identifierCount++; |
There was a problem hiding this comment.
We only use identifierCount for diagnostics purposes. Is there a reason to make it conditional?
There was a problem hiding this comment.
I didn’t think it was super important, but realized it was double-counting invalid identifiers, and it was easy to make it more accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, put the invalid identifier text in the identifier node. (This is the same strategy we used to clean up the parse tree when private identifiers are used in places where private identifiers should never actually be parsed.)
Fixes one cause of #39854