Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11591 added support for parsing and emitting JSX spread children, however
transformers/jsx.ts
ignoresJsxExpression#dotDotDotToken
, so roughly it transforms<div>{...todos}</div>
->React.createElement("div", null, todos)
vs.React.createElement("div", null, ...todos)
.This isn't a problem for
React.createElement()
because that runtime treats both cases equivalently (it flattens children), however it is an issue for pickier runtimes.This PR adds
factory.createSpreadElement()
totransformers/jsx.ts
ifJsxExpression#dotDotDotToken
is defined.