Skip to content

Improve parameter decorator inference #47591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Fireboltofdeath
Copy link

Fixes #30102
Fixes #33260
Related #43132

  • Correctly infers undefined key for constructors
  • Correctly infers class type
  • Adds inference for method names
  • Adds inference for parameter index
  • Fixes incorrect propertyKey parameter on ParameterDecorator type declaration

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…mprove-parameter-decorator-inference
@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 25, 2022
@sorgloomer
Copy link

It seems inference for decorators shipped in TypeScript 5.

@Fireboltofdeath
Copy link
Author

It would appear, yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Infer method name for parameter decorator Incorrect function type signature for ParameterDecorator
4 participants