Fix @link https:// formatting #47705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve .d.ts formatting of `@link`,`@linkcode`,`@linkplain`. Fixes #46734 1. Previously, `@link` incorrectly put a space between "https" and "://" when formatting jsdoc for editors. Now it does not. 2. When fixing the same output for .d.ts, I discovered that all `@link` tags were formatted as `@link`, even if they were `@linkcode` or `@linkplain`. I fixed that too.
typescript-bot
added
Author: Team
For Milestone Bug
|
Note that the .d.ts formatting code is duplicated with the services formatting; the former doesn't do name resolution so doesn't require a checker, and I don't really think proper .d.ts comment formatting is high enough priority to extract the common parts of the code to compiler/utilities.ts. Maybe it is though! Let me know what you think. |
gabritto
approved these changes
Feb 2, 2022
jakebailey
approved these changes
Feb 2, 2022
|
Oops, forgot to re-run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve .d.ts formatting of
@link,@linkcode,@linkplain.Fixes #46734
@linkincorrectly put a space between "https" and "://" when formatting jsdoc for editors. Now it does not.@linktags were formatted as@link, even if they were@linkcodeor@linkplain. I fixed that too.