Skip to content

fix types : export the base as children are exported #4815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2015
Merged

fix types : export the base as children are exported #4815

merged 1 commit into from
Sep 16, 2015

Conversation

basarat
Copy link
Contributor

@basarat basarat commented Sep 16, 2015

Fixes error:

../src/compiler/types.ts(2130,63): error TS4022: Extends clause of exported interface 'CommandLineOptionOfPrimitiveType' has or is using private name 'CommandLineOptionBase'.
../src/compiler/types.ts(2135,60): error TS4022: Extends clause of exported interface 'CommandLineOptionOfCustomType' has or is using private name 'CommandLineOptionBase'.

Ref : https://travis-ci.org/TypeStrong/ntypescript/builds/80545233#L143-L144

🌹

@DanielRosenwasser
Copy link
Member

Sorry about that, thanks for the fix @basarat!

DanielRosenwasser added a commit that referenced this pull request Sep 16, 2015
@DanielRosenwasser
Merge pull request #4815 from basarat/patch-1
c9170b8 
fix types : export the base as children are exported
@DanielRosenwasser DanielRosenwasser merged commit c9170b8 into microsoft:master Sep 16, 2015
@DanielRosenwasser
Copy link
Member

Wait, I think this might need to go into release-1.6 as well @mhegazy.

@DanielRosenwasser
Copy link
Member

Also, why did our tests never catch this?

@DanielRosenwasser
Copy link
Member

Actually, it seems that this only occurs with --declaration and no --stripInternal.

@basarat basarat deleted the patch-1 branch September 16, 2015 03:58
@basarat
Copy link
Contributor Author

basarat commented Sep 16, 2015

Also, why did our tests never catch this?

As you mentioned: only occurs with --declaration and no --stripInternal 👍 Glad I could be of service.

@basarat basarat mentioned this pull request Mar 2, 2016
Merged
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basarat @DanielRosenwasser @msftclas