Skip to content

fix(48948): constructor can't be the name of class accessors and generators #48954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2022
Merged

fix(48948): constructor can't be the name of class accessors and generators #48954

merged 3 commits into from
May 13, 2022

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #48948

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label May 4, 2022
DanielRosenwasser
DanielRosenwasser approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good. We should probably issue these errors in plain JS files. @sandersn will the current logic do that? Will we need a test?

@sandersn
Copy link
Member

  1. The new errors need to be added to the plainJSErrors list in program.ts.
  2. I think the tests are in $tests/cases/conformance/salsa/plainJSErrors.ts although I'm not certain.

sandersn
sandersn approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Please add the new errors to plainJSErrors in program.ts and a short test to plainJSGrammarErrors.ts in tests/conformance/salsa

@DanielRosenwasser DanielRosenwasser merged commit 0414dee into microsoft:main May 13, 2022
@mhofman mhofman mentioned this pull request Jan 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

@sandersn sandersn Awaiting requested review from sandersn

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

constructor can't be the name of class accessors and generators.
4 participants
@a-tarasyuk @sandersn @DanielRosenwasser @typescript-bot