-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Update CONTRIBUTING.md to mention issue claiming and force pushing #49090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There are two symmetric behaviors I want to discourage - cookie licking, and asking if it's OK to eat the cookie. DraftIssue-claimingIf you intend to work on an issue, please avoid leaving comments like "I'm going to work on this". There are a few reasons for this. These comments tend to discourage anyone from working in the area, yet many issues are much more difficult than they first appear, and you might find yourself trying to fix several issues before finding one that can be completed. Many issues have a long trail of people indicating that they're going to try to fix it, but no PR. Conversely, you do not need to ask anyone's permission before starting work on an issue. It's always fine to try! We ask that you choose issues tagged in the "Backlog" milestone as these are issues that we've identified as needing fixes / implementations. The sheer quantity of open issues, combined with their general difficulty, makes it extremely unlikely that you and another contributor are a) working on the same issue and b) both going to find a solution. |
I think that reads well to me. |
- Conversely, you do not need to ask anyone's permission before starting work on an issue
+ Conversely, you do not need to ask anyone's permission before starting work on an issue marked as "help wanted" |
Updated to match the draft + Daniel's change. |
@RyanCavanaugh Any other changes you're looking for here? |
shipit.gif |
Let me know if you want these worded differently, or that link to the old Raymond blog removed.