Skip to content

fix(49566): Implicit this.property completions not returned while writing property #49574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2022
Merged

fix(49566): Implicit this.property completions not returned while writing property #49574

merged 2 commits into from
Jun 16, 2022

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #49566

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jun 16, 2022
jakebailey
jakebailey reviewed Jun 16, 2022
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I am curious whether or not it's getThisContainer that's broken here.

@a-tarasyuk a-tarasyuk requested a review from jakebailey June 16, 2022 19:29
jakebailey
jakebailey approved these changes Jun 16, 2022
View reviewed changes
@jakebailey jakebailey merged commit f83ce9b into microsoft:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

Assignees

@jakebailey jakebailey

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implicit this.property completions not returned while writing property
3 participants
@a-tarasyuk @jakebailey @typescript-bot