-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Fix implied formats, file watching, new source file creating during edits #50098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0eaf0f2
Add test where module resolution cache is not local and hence doesnt …
sheetalkamat d67505c
Ensure module resolution cache is passed through in watch mode
sheetalkamat 46bfa62
Remove unnecessary setting of impliedFormat which should anyways be d…
sheetalkamat 0345627
Add test for packge.json changing and modifying implied format
sheetalkamat 3b174e7
Distinguish between package.json watch and affecting file location watch
sheetalkamat 5a63c5b
Pass in failed lookup and affected file locations for source file's i…
sheetalkamat f5c6ffe
Add diagnostic for explaining file's implied format if based on packa…
sheetalkamat 7500659
Watch implied format dependencies for modules and schedule update on …
sheetalkamat d932066
For program if implied node format doesnt match create new source fil…
sheetalkamat 0493471
Modify tests to show package.json being watched irrespective of folde…
sheetalkamat 0dd2e7d
Check file path if it can be watched before watching package.json file
sheetalkamat 73f56b2
Because we are watching package.json files and failed lookups its saf…
sheetalkamat a3a0677
Remove todos
sheetalkamat 7e272d6
Fix the incorrect merge
sheetalkamat a9aa65f
Pickup PackageJsonInfo renames from #50088
sheetalkamat 297b907
Rename
sheetalkamat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.