Skip to content

feat(48665): tsconfig "extends" field ignores "exports" field of source package #50955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 20, 2022
Merged

feat(48665): tsconfig "extends" field ignores "exports" field of source package #50955

merged 7 commits into from
Dec 20, 2022

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #48665

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 26, 2022
@a-tarasyuk
Copy link
Contributor Author

it should just need to be swapped to nodeNextModuleNameResolver and pass { moduleResolution: ModuleResolutionKind.NodeNext }

I tried however it didn't process tsconfig files, I added changes to loadJSOrExactTSFileName. Maybe need to add additional tests to cover more cases. @weswigham Could you please review these changes?

andrewbranch
andrewbranch approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, but would like to get more naming ideas

sandersn
sandersn reviewed Dec 17, 2022
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real new suggestions, but a couple of edits to the English.

@andrewbranch @sandersn
Apply suggestions from code review
e9efef2 
Co-authored-by: Nathan Shively-Sanders <[email protected]>
@sandersn sandersn merged commit 5951ee9 into microsoft:main Dec 20, 2022
@andrewbranch andrewbranch mentioned this pull request Mar 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@sandersn sandersn sandersn approved these changes

@navya9singh navya9singh Awaiting requested review from navya9singh

Assignees

@navya9singh navya9singh

Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tsconfig "extends" field ignores "exports" field of source package
5 participants
@a-tarasyuk @sandersn @andrewbranch @typescript-bot @navya9singh