Fix auto-imports of redirected packages while making ExportInfoMap smaller? #52718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@andrewbranch do you remember if this PR was worthwhile at the time that you opened it? Is it worth keeping around until you have time to work on it again? |
|
I think the ideas from this can be incorporated into Corsa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while investigating #52661 that redirected packages might not be behaving as intended in the ExportInfoMap. Exports from redirected source files are present in the ExportInfoMap, but later
forEachFileNameOfModulefetches redirects and considers them in its logic, so there’s definitely some amount of redundant work and storage. Currently, however, there are a couple places where we get the redirect target instead of the source for a module specifier computation, so there are cases where auto-imports that should be available via a redirect don’t work at all.