-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Update baselines missed in PR #53281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's definitely not desirable - I've been looking at it and it seems like #51580 and #52837 conflict semantically, to the tune of partially re-breaking what #52837 fixed. (Also the In the meantime, we can revert #51580 to put |
(Specifically, by no longer passing in the |
Sent #53283. |
<Foo {...{ | ||
a: (x) => 10, | ||
b: (arg) => { arg.toString(); }, | ||
~~~ | ||
!!! error TS18046: 'arg' is of type 'unknown'. | ||
}} />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I see this is the only "unwanted" change that has been found on main
. However... this is exactly how regular call expressions work: TS playground. So perhaps... this was just working accidentally before. I feel like this should be a separate issue to make it work for both JSX and regular calls (if that's desired)
I took a look at those changes and I think that some of them are not desired. |
#51580 had not been updated in a while and has some baseline changes.
I am not sure the behavior of
intraExpressionInferencesJsx
is desirable here. @Andarist