Skip to content

Fix incorrect assert about configFileName when watch is created with explicit options, projectReferences etc #53468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2023
Merged

Fix incorrect assert about configFileName when watch is created with explicit options, projectReferences etc #53468

merged 2 commits into from
Mar 23, 2023

Conversation

sheetalkamat
Copy link
Member

Fixes issue detected in TypeStrong/ts-loader#1601

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 23, 2023
@sheetalkamat
Copy link
Member Author

@typescript-bot cherry-pick this to release-5.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 23, 2023 •
edited
Loading

Heya @sheetalkamat, I've started to run the task to cherry-pick this into release-5.0 on this PR at fadd862. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Mar 23, 2023
Closed
@typescript-bot
Copy link
Collaborator

Hey @sheetalkamat, I've opened #53469 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Mar 23, 2023
@sheetalkamat @typescript-bot
Cherry-pick PR microsoft#53468 into release-5.0
7941c9d 
Component commits:
e133b08 Add failing test

fadd862 Fix incorrect assert
@sheetalkamat sheetalkamat merged commit c66f8de into main Mar 23, 2023
@sheetalkamat sheetalkamat deleted the watchApi branch March 23, 2023 19:40
sheetalkamat added a commit that referenced this pull request Mar 23, 2023
@sheetalkamat
Fix incorrect assert about configFileName when watch is created with …
d397c54 
…explicit options, projectReferences etc (#53468)
@sheetalkamat sheetalkamat mentioned this pull request Mar 23, 2023
Merged
sheetalkamat added a commit that referenced this pull request Mar 23, 2023
@sheetalkamat
Pick PR #53468 (Fix incorrect assert about configFi...) into release-…
e674ef3 
…5.0 (#53471)
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 5.0.3 milestone Mar 23, 2023
@johnnyreilly johnnyreilly mentioned this pull request Apr 10, 2023
Merged
drivron pushed a commit to scenari/typescript that referenced this pull request Sep 14, 2023
@sheetalkamat
Pick PR microsoft#53468 (Fix incorrect assert about configFi...) into…
b9811b8 
… release-5.0 (microsoft#53471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees

@sheetalkamat sheetalkamat

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
TypeScript 5.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@sheetalkamat @typescript-bot @jakebailey @DanielRosenwasser