Skip to content

Fix double-emit in constructor #53547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2023
Merged

Fix double-emit in constructor #53547

merged 2 commits into from
Mar 27, 2023

Conversation

rbuckton
Copy link
Contributor

Fixes the emit change in #53268 to avoid duplicate emit when super() is not found.

Fixes #53448

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 27, 2023
@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-5.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-5.0 on this PR at d9a6d9a. You can monitor the build here.

@rbuckton rbuckton merged commit 85ef01d into main Mar 27, 2023
@rbuckton rbuckton deleted the fix-53448 branch March 27, 2023 22:16
@typescript-bot typescript-bot mentioned this pull request Mar 27, 2023
Merged
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #53550 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Mar 27, 2023
@rbuckton @typescript-bot
Cherry-pick PR microsoft#53547 into release-5.0
88fe455 
Component commits:
a937637 Fix double-emit in constructor

d9a6d9a Add extra test
DanielRosenwasser pushed a commit that referenced this pull request Mar 28, 2023
@rbuckton
🤖 Pick PR #53547 (Fix double-emit in constructor) into release-5.0 (#…
aebd31b 
…53550)

Co-authored-by: Ron Buckton <[email protected]>
drivron pushed a commit to scenari/typescript that referenced this pull request Sep 14, 2023
@rbuckton
🤖 Pick PR microsoft#53547 (Fix double-emit in constructor) into relea…
620f6d2 
…se-5.0 (microsoft#53550)

Co-authored-by: Ron Buckton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@weswigham weswigham weswigham approved these changes

@jakebailey jakebailey jakebailey approved these changes

Assignees

@rbuckton rbuckton

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double Emit of Contructor when using Getter Decorators
5 participants
@rbuckton @DanielRosenwasser @typescript-bot @weswigham @jakebailey