Constraints for generic tuple types #53672

ahejlsberg · 2023-04-05T15:11:39Z

ahejlsberg · 2023-04-05T20:14:30Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2023-04-05T20:14:33Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 812b92f. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-05T20:14:33Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 812b92f. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-05T20:14:33Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 812b92f. You can monitor the build here.

typescript-bot · 2023-04-05T20:14:33Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 812b92f. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-05T20:14:33Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 812b92f. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-05T20:26:31Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/53672/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-04-05T22:05:08Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/53672/merge:

Something interesting changed - please have a look.

Details

pmndrs/zustand

tsconfig.json

error TS2321: Excessive stack depth comparing types '"setState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/subscribeWithSelector", never]]>'.
- tests/context.test.tsx#L82
error TS2321: Excessive stack depth comparing types '"getState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/immer", never]]>'.
- tests/middlewareTypes.test.tsx#L41
error TS2321: Excessive stack depth comparing types '"setState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/immer", never]]>'.
- tests/middlewareTypes.test.tsx#L41
error TS2321: Excessive stack depth comparing types '"getState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/devtools", never]]>'.
- tests/middlewareTypes.test.tsx#L95
error TS2321: Excessive stack depth comparing types '"setState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/devtools", never]]>'.
- tests/middlewareTypes.test.tsx#L95
error TS2321: Excessive stack depth comparing types '"getState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/subscribeWithSelector", never]]>'.
- tests/middlewareTypes.test.tsx#L122
error TS2321: Excessive stack depth comparing types '"getState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/persist", unknown]]>'.
- tests/middlewareTypes.test.tsx#L171
error TS2321: Excessive stack depth comparing types '"setState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/persist", unknown]]>'.
- tests/middlewareTypes.test.tsx#L171

typescript-bot · 2023-04-05T22:19:03Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-04-06T00:59:33Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53672

_Metric	_main	₅₃₆₇₂	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{364,802k (± 0.01%)}	_{364,814k (± 0.01%)}	_~	_364,776k	_364,841k	_{p=0.470 n=6}
_{Parse Time}	_{3.52s (± 0.43%)}	_{3.55s (± 0.52%)}	_~	_3.53s	_3.57s	_{p=0.059 n=6}
_{Bind Time}	_{1.17s (± 0.71%)}	_{1.18s (± 0.83%)}	_~	_1.17s	_1.19s	_{p=0.273 n=6}
_{Check Time}	_{9.56s (± 0.38%)}	_{9.54s (± 0.47%)}	_~	_9.50s	_9.62s	_{p=0.333 n=6}
_{Emit Time}	_{7.97s (± 0.60%)}	_{8.01s (± 0.88%)}	_~	_7.92s	_8.09s	_{p=0.422 n=6}
_{Total Time}	_{22.23s (± 0.15%)}	_{22.27s (± 0.47%)}	_~	_22.13s	_22.43s	_{p=0.574 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,542k (± 0.02%)}	_{193,149k (± 0.74%)}	_~	_192,534k	_196,049k	_{p=0.107 n=6}
_{Parse Time}	_{1.57s (± 1.36%)}	_{1.60s (± 1.29%)}	_~	_1.56s	_1.62s	_{p=0.062 n=6}
_{Bind Time}	_{0.82s (± 0.66%)}	_{0.82s (± 0.50%)}	_~	_0.81s	_0.82s	_{p=0.054 n=6}
_{Check Time}	_{10.34s (± 0.65%)}	_{10.34s (± 0.39%)}	_~	_10.26s	_10.38s	_{p=0.469 n=6}
_{Emit Time}	_{3.01s (± 0.71%)}	_{2.99s (± 1.25%)}	_~	_2.94s	_3.03s	_{p=0.466 n=6}
_{Total Time}	_{15.75s (± 0.44%)}	_{15.74s (± 0.31%)}	_~	_15.68s	_15.80s	_{p=0.872 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,678k (± 0.00%)}	_{345,674k (± 0.01%)}	_~	_345,641k	_345,697k	_{p=1.000 n=6}
_{Parse Time}	_{2.71s (± 0.20%)}	_{2.72s (± 0.46%)}	_{+0.02s (+ 0.55%)}	_2.71s	_2.74s	_{p=0.025 n=6}
_{Bind Time}	_{1.08s (± 0.70%)}	_{1.08s (± 0.38%)}	_~	_1.08s	_1.09s	_{p=1.000 n=6}
_{Check Time}	_{7.78s (± 0.68%)}	_{7.76s (± 0.49%)}	_~	_7.72s	_7.83s	_{p=0.871 n=6}
_{Emit Time}	_{4.43s (± 0.84%)}	_{4.46s (± 0.46%)}	_~	_4.43s	_4.48s	_{p=0.141 n=6}
_{Total Time}	_{16.00s (± 0.47%)}	_{16.03s (± 0.36%)}	_~	_15.94s	_16.12s	_{p=0.374 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,058k (± 0.00%)}	_{300,066k (± 0.01%)}	_~	_300,040k	_300,100k	_{p=0.470 n=6}
_{Parse Time}	_{2.15s (± 0.24%)}	_{2.16s (± 0.41%)}	_{+0.01s (+ 0.62%)}	_2.15s	_2.17s	_{p=0.020 n=6}
_{Bind Time}	_{1.24s (± 0.68%)}	_{1.24s (± 0.61%)}	_~	_1.23s	_1.25s	_{p=0.432 n=6}
_{Check Time}	_{7.22s (± 0.52%)}	_{7.21s (± 0.33%)}	_~	_7.18s	_7.25s	_{p=0.678 n=6}
_{Emit Time}	_{4.33s (± 0.57%)}	_{4.32s (± 0.68%)}	_~	_4.27s	_4.36s	_{p=0.514 n=6}
_{Total Time}	_{14.94s (± 0.27%)}	_{14.93s (± 0.30%)}	_~	_14.88s	_14.99s	_{p=0.872 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,419k (± 0.00%)}	_{479,436k (± 0.01%)}	_~	_479,412k	_479,481k	_{p=0.378 n=6}
_{Parse Time}	_{3.24s (± 0.37%)}	_{3.25s (± 0.57%)}	_~	_3.22s	_3.27s	_{p=0.324 n=6}
_{Bind Time}	_{0.95s (± 0.54%)}	_{0.95s (± 0.43%)}	_~	_0.95s	_0.96s	_{p=0.595 n=6}
_{Check Time}	_{18.21s (± 0.31%)}	_{18.18s (± 0.25%)}	_~	_18.14s	_18.25s	_{p=0.373 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.40s (± 0.26%)}	_{22.38s (± 0.22%)}	_~	_22.33s	_22.45s	_{p=0.872 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{559,796k (± 0.03%)}	_{559,700k (± 0.01%)}	_~	_559,567k	_559,780k	_{p=0.297 n=6}
_{Parse Time}	_{3.98s (± 0.26%)}	_{3.98s (± 0.29%)}	_~	_3.97s	_4.00s	_{p=0.511 n=6}
_{Bind Time}	_{1.75s (± 0.70%)}	_{1.74s (± 0.32%)}	_~	_1.73s	_1.74s	_{p=0.137 n=6}
_{Check Time}	_{3.06s (± 0.40%)}	_{3.07s (± 0.44%)}	_~	_3.06s	_3.10s	_{p=0.324 n=6}
_{Emit Time}	_{0.09s (± 4.45%)}	_{0.09s (± 4.45%)}	_~	_0.09s	_0.10s	_{p=1.000 n=6}
_{Total Time}	_{8.87s (± 0.28%)}	_{8.89s (± 0.24%)}	_~	_8.86s	_8.92s	_{p=0.293 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₆₇₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

awerlogus · 2023-04-06T12:00:26Z

@ahejlsberg will this PR fix also #53256?

ahejlsberg · 2023-04-07T14:41:50Z

@awerlogus Yes, I'll make sure it does.

ahejlsberg · 2023-04-07T14:50:23Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot test top100

typescript-bot · 2023-04-07T14:50:26Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at ed4e812. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-07T14:50:26Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at ed4e812. You can monitor the build here.

typescript-bot · 2023-04-07T14:50:26Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at ed4e812. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-07T14:50:27Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at ed4e812. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-07T15:01:30Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/53672/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-04-07T16:34:24Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/53672/merge:

Something interesting changed - please have a look.

Details

pmndrs/zustand

tsconfig.json

error TS2321: Excessive stack depth comparing types '"setState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/subscribeWithSelector", never]]>'.
- tests/context.test.tsx#L82
error TS2321: Excessive stack depth comparing types '"getState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/immer", never]]>'.
- tests/middlewareTypes.test.tsx#L41
error TS2321: Excessive stack depth comparing types '"setState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/immer", never]]>'.
- tests/middlewareTypes.test.tsx#L41
error TS2321: Excessive stack depth comparing types '"getState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/devtools", never]]>'.
- tests/middlewareTypes.test.tsx#L95
error TS2321: Excessive stack depth comparing types '"setState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/devtools", never]]>'.
- tests/middlewareTypes.test.tsx#L95
error TS2321: Excessive stack depth comparing types '"getState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/subscribeWithSelector", never]]>'.
- tests/middlewareTypes.test.tsx#L122
error TS2321: Excessive stack depth comparing types '"getState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/persist", unknown]]>'.
- tests/middlewareTypes.test.tsx#L171
error TS2321: Excessive stack depth comparing types '"setState"' and 'keyof Mutate<StoreApi<T>, [...Mps, ["zustand/persist", unknown]]>'.
- tests/middlewareTypes.test.tsx#L171

typescript-bot · 2023-04-07T16:49:12Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

awerlogus · 2023-04-12T18:46:48Z

@ahejlsberg please take a look at these two examples which are also related to generic tuple types

// No error, but expected
const a = <T extends [unknown]>(x: T): T[0] => 123

// string type, but number value
const b = a([''])

declare const a: <T extends [unknown]>(x: T[0]) => void

// const a: <[unknown]>(x: unknown) => void
a('123')

// It would be nice if type of 0 element of T will be inferred from type of argument passed as x

ahejlsberg · 2023-04-24T23:23:34Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2023-04-24T23:23:37Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at ee429dd. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-24T23:23:37Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at ee429dd. You can monitor the build here.

typescript-bot · 2023-04-24T23:23:37Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at ee429dd. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-24T23:23:37Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at ee429dd. You can monitor the build here.

typescript-bot · 2023-04-24T23:23:37Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at ee429dd. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-24T23:48:27Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53672

_Metric	_main	₅₃₆₇₂	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,228k (± 0.01%)}	_{365,187k (± 0.01%)}	_~	_365,131k	_365,239k	_{p=0.173 n=6}
_{Parse Time}	_{3.54s (± 0.21%)}	_{3.55s (± 0.66%)}	_~	_3.52s	_3.58s	_{p=0.164 n=6}
_{Bind Time}	_{1.18s (± 1.07%)}	_{1.18s (± 0.88%)}	_~	_1.17s	_1.19s	_{p=0.560 n=6}
_{Check Time}	_{9.53s (± 0.50%)}	_{9.55s (± 0.59%)}	_~	_9.49s	_9.63s	_{p=0.468 n=6}
_{Emit Time}	_{7.90s (± 0.29%)}	_{7.89s (± 0.67%)}	_~	_7.84s	_7.99s	_{p=0.121 n=6}
_{Total Time}	_{22.14s (± 0.33%)}	_{22.17s (± 0.29%)}	_~	_22.11s	_22.25s	_{p=0.421 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,643k (± 0.02%)}	_{193,765k (± 0.89%)}	_~	_192,611k	_196,208k	_{p=0.336 n=6}
_{Parse Time}	_{1.59s (± 1.32%)}	_{1.60s (± 1.23%)}	_~	_1.57s	_1.63s	_{p=0.139 n=6}
_{Bind Time}	_{0.83s (± 0.62%)}	_{0.83s (± 0.91%)}	_~	_0.82s	_0.84s	_{p=0.784 n=6}
_{Check Time}	_{10.26s (± 0.41%)}	_{10.28s (± 0.45%)}	_~	_10.23s	_10.37s	_{p=0.466 n=6}
_{Emit Time}	_{3.02s (± 1.18%)}	_{3.03s (± 1.37%)}	_~	_3.00s	_3.11s	_{p=0.806 n=6}
_{Total Time}	_{15.70s (± 0.21%)}	_{15.74s (± 0.26%)}	_~	_15.70s	_15.81s	_{p=0.063 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,785k (± 0.01%)}	_{345,790k (± 0.00%)}	_~	_345,772k	_345,816k	_{p=1.000 n=6}
_{Parse Time}	_{2.72s (± 0.66%)}	_{2.71s (± 0.38%)}	_~	_2.70s	_2.73s	_{p=0.566 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.09s (± 0.75%)}	_~	_1.08s	_1.10s	_{p=0.929 n=6}
_{Check Time}	_{7.84s (± 0.32%)}	_{7.86s (± 0.27%)}	_~	_7.83s	_7.89s	_{p=0.169 n=6}
_{Emit Time}	_{4.45s (± 0.80%)}	_{4.45s (± 0.81%)}	_~	_4.39s	_4.49s	_{p=1.000 n=6}
_{Total Time}	_{16.10s (± 0.32%)}	_{16.11s (± 0.27%)}	_~	_16.07s	_16.17s	_{p=1.000 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,049k (± 0.00%)}	_{300,068k (± 0.01%)}	_~	_300,043k	_300,093k	_{p=0.229 n=6}
_{Parse Time}	_{2.16s (± 0.56%)}	_{2.15s (± 0.70%)}	_~	_2.14s	_2.18s	_{p=0.621 n=6}
_{Bind Time}	_{1.24s (± 0.44%)}	_{1.23s (± 0.89%)}	_~	_1.22s	_1.25s	_{p=0.227 n=6}
_{Check Time}	_{7.25s (± 0.31%)}	_{7.24s (± 0.19%)}	_~	_7.22s	_7.26s	_{p=0.871 n=6}
_{Emit Time}	_{4.38s (± 0.91%)}	_{4.39s (± 0.96%)}	_~	_4.36s	_4.47s	_{p=1.000 n=6}
_{Total Time}	_{15.02s (± 0.44%)}	_{15.02s (± 0.42%)}	_~	_14.94s	_15.13s	_{p=0.873 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,578k (± 0.01%)}	_{481,621k (± 0.01%)}	_~	_481,571k	_481,646k	_{p=0.093 n=6}
_{Parse Time}	_{3.24s (± 0.17%)}	_{3.24s (± 0.54%)}	_~	_3.22s	_3.27s	_{p=0.663 n=6}
_{Bind Time}	_{0.94s (± 0.55%)}	_{0.94s (± 0.67%)}	_~	_0.93s	_0.95s	_{p=0.386 n=6}
_{Check Time}	_{17.78s (± 0.28%)}	_{17.95s (± 0.77%)}	_{+0.17s (+ 0.95%)}	_17.79s	_18.10s	_{p=0.020 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.95s (± 0.24%)}	_{22.13s (± 0.65%)}	_{+0.17s (+ 0.79%)}	_21.97s	_22.31s	_{p=0.015 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,570k (± 0.01%)}	_{560,597k (± 0.03%)}	_~	_560,453k	_560,752k	_{p=0.873 n=6}
_{Parse Time}	_{3.98s (± 0.25%)}	_{4.00s (± 0.19%)}	_{+0.02s (+ 0.50%)}	_3.99s	_4.01s	_{p=0.007 n=6}
_{Bind Time}	_{1.76s (± 0.31%)}	_{1.77s (± 0.43%)}	_~	_1.76s	_1.78s	_{p=0.476 n=6}
_{Check Time}	_{3.06s (± 0.32%)}	_{3.05s (± 0.68%)}	_~	_3.01s	_3.07s	_{p=0.157 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.89s (± 0.20%)}	_{8.90s (± 0.28%)}	_~	_8.86s	_8.93s	_{p=0.373 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₆₇₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-04-25T01:10:47Z

Hey @ahejlsberg, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

typescript-bot · 2023-04-25T01:36:30Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/53672/merge:

Something interesting changed - please have a look.

Details

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2321: Excessive stack depth comparing types '[Head<_ReverseTail<ExtractParameters<T>>>, ReverseHead<ExtractParameters<T>> extends readonly unknown[] ? (readonly unknown[] & ReverseHead<...>)[number] : never]' and '[Head<_ReverseTail<ExtractParameters<T>>>, ...unknown[][]]'.
- file:///mnt/ts_downloads/hyper/node_modules/reselect/es/versionedTypes/ts47-mergeParameters.d.ts#L16 in tsconfig.json
error TS2589: Type instantiation is excessively deep and possibly infinite.
- file:///mnt/ts_downloads/hyper/node_modules/reselect/es/versionedTypes/ts47-mergeParameters.d.ts#L16 in tsconfig.json
- file:///mnt/ts_downloads/hyper/node_modules/reselect/es/types.d.ts#L47 in tsconfig.json
error TS2321: Excessive stack depth comparing types '[Head<_ReverseTail<ExtractParameters<S>>>, ReverseHead<ExtractParameters<S>> extends readonly unknown[] ? (readonly unknown[] & ReverseHead<...>)[number] : never]' and '[Head<_ReverseTail<ExtractParameters<S>>>, ...unknown[][]]'.
- file:///mnt/ts_downloads/hyper/node_modules/reselect/es/types.d.ts#L47 in tsconfig.json

ahejlsberg · 2023-04-25T16:23:51Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2023-04-25T16:23:55Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 417f154. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-25T16:23:55Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 417f154. You can monitor the build here.

typescript-bot · 2023-04-25T16:23:55Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 417f154. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-25T16:23:55Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 417f154. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-25T16:23:55Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 417f154. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-25T16:35:33Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/53672/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-04-25T16:39:47Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53672

_Metric	_main	₅₃₆₇₂	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,211k (± 0.01%)}	_{365,192k (± 0.00%)}	_~	_365,181k	_365,212k	_{p=0.126 n=6}
_{Parse Time}	_{3.54s (± 0.52%)}	_{3.57s (± 0.41%)}	_{+0.03s (+ 0.85%)}	_3.55s	_3.59s	_{p=0.018 n=6}
_{Bind Time}	_{1.18s (± 0.44%)}	_{1.18s (± 0.44%)}	_~	_1.17s	_1.18s	_{p=1.000 n=6}
_{Check Time}	_{9.56s (± 0.33%)}	_{9.56s (± 0.62%)}	_~	_9.50s	_9.63s	_{p=0.872 n=6}
_{Emit Time}	_{7.92s (± 0.66%)}	_{7.93s (± 0.89%)}	_~	_7.85s	_8.03s	_{p=0.936 n=6}
_{Total Time}	_{22.19s (± 0.21%)}	_{22.24s (± 0.60%)}	_~	_22.09s	_22.42s	_{p=0.688 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,204k (± 0.66%)}	_{192,716k (± 0.03%)}	_~	_192,646k	_192,777k	_{p=0.936 n=6}
_{Parse Time}	_{1.58s (± 1.42%)}	_{1.59s (± 0.74%)}	_~	_1.57s	_1.60s	_{p=0.933 n=6}
_{Bind Time}	_{0.83s (± 0.66%)}	_{0.82s (± 0.77%)}	_~	_0.81s	_0.83s	_{p=0.201 n=6}
_{Check Time}	_{10.21s (± 0.40%)}	_{10.33s (± 0.36%)}	_{+0.12s (+ 1.19%)}	_10.27s	_10.37s	_{p=0.005 n=6}
_{Emit Time}	_{3.01s (± 0.64%)}	_{3.02s (± 0.65%)}	_~	_3.00s	_3.05s	_{p=0.220 n=6}
_{Total Time}	_{15.63s (± 0.31%)}	_{15.77s (± 0.31%)}	_{+0.14s (+ 0.90%)}	_15.70s	_15.83s	_{p=0.006 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,795k (± 0.00%)}	_{345,783k (± 0.00%)}	_~	_345,762k	_345,798k	_{p=0.171 n=6}
_{Parse Time}	_{2.73s (± 0.51%)}	_{2.71s (± 0.73%)}	_~	_2.69s	_2.75s	_{p=0.255 n=6}
_{Bind Time}	_{1.08s (± 0.50%)}	_{1.09s (± 0.75%)}	_~	_1.08s	_1.10s	_{p=0.859 n=6}
_{Check Time}	_{7.82s (± 0.28%)}	_{7.86s (± 0.59%)}	_~	_7.80s	_7.92s	_{p=0.172 n=6}
_{Emit Time}	_{4.46s (± 0.57%)}	_{4.49s (± 1.06%)}	_~	_4.40s	_4.54s	_{p=0.145 n=6}
_{Total Time}	_{16.10s (± 0.23%)}	_{16.15s (± 0.59%)}	_~	_16.00s	_16.26s	_{p=0.170 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,058k (± 0.01%)}	_{300,065k (± 0.01%)}	_~	_300,034k	_300,106k	_{p=0.422 n=6}
_{Parse Time}	_{2.14s (± 0.76%)}	_{2.15s (± 0.49%)}	_~	_2.13s	_2.16s	_{p=0.802 n=6}
_{Bind Time}	_{1.23s (± 0.89%)}	_{1.24s (± 0.68%)}	_~	_1.22s	_1.24s	_{p=0.465 n=6}
_{Check Time}	_{7.23s (± 0.54%)}	_{7.25s (± 0.35%)}	_~	_7.21s	_7.28s	_{p=0.195 n=6}
_{Emit Time}	_{4.34s (± 0.61%)}	_{4.38s (± 0.37%)}	_{+0.04s (+ 0.92%)}	_4.36s	_4.40s	_{p=0.043 n=6}
_{Total Time}	_{14.94s (± 0.44%)}	_{15.00s (± 0.24%)}	_~	_14.96s	_15.06s	_{p=0.147 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,590k (± 0.01%)}	_{481,534k (± 0.01%)}	_{-56k (- 0.01%)}	_481,496k	_481,580k	_{p=0.045 n=6}
_{Parse Time}	_{3.24s (± 0.34%)}	_{3.25s (± 0.13%)}	_~	_3.25s	_3.26s	_{p=0.054 n=6}
_{Bind Time}	_{0.94s (± 0.67%)}	_{0.94s (± 0.86%)}	_~	_0.93s	_0.95s	_{p=0.432 n=6}
_{Check Time}	_{17.84s (± 0.35%)}	_{17.87s (± 0.63%)}	_~	_17.73s	_18.00s	_{p=0.573 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.02s (± 0.32%)}	_{22.06s (± 0.52%)}	_~	_21.91s	_22.19s	_{p=0.423 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,571k (± 0.02%)}	_{560,583k (± 0.02%)}	_~	_560,477k	_560,706k	_{p=0.810 n=6}
_{Parse Time}	_{3.99s (± 0.34%)}	_{3.99s (± 0.32%)}	_~	_3.98s	_4.01s	_{p=0.871 n=6}
_{Bind Time}	_{1.76s (± 0.31%)}	_{1.77s (± 0.42%)}	_~	_1.76s	_1.78s	_{p=0.137 n=6}
_{Check Time}	_{3.04s (± 0.34%)}	_{3.06s (± 0.38%)}	_{+0.02s (+ 0.49%)}	_3.05s	_3.08s	_{p=0.047 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.88s (± 0.15%)}	_{8.91s (± 0.11%)}	_{+0.03s (+ 0.30%)}	_8.90s	_8.92s	_{p=0.007 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₆₇₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-04-25T18:25:48Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-04-25T18:47:04Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/53672/merge:

Everything looks good!

ahejlsberg · 2023-04-25T22:01:27Z

Tests all look good and performance is unaffected (though some noise in the various runs). This one is ready to merge.

jcalz · 2023-05-13T16:18:02Z

Is this a separate issue?

type NTuple<N extends number, A extends any[] = []> =
    A['length'] extends N ? A : NTuple<N, [any, ...A]>;

type X<N extends number> = `${[...NTuple<N>]['length']}`; // error
//                                           ^? (property) length: number
// Type '[...NTuple<N, []>]["length"]' is not assignable to type 
// 'string | number | bigint | boolean | null | undefined'.(2322)

Playground link

Seems related but maybe something about generic recursive tuple types makes this different? Comes from this SO question

ahejlsberg added 2 commits April 5, 2023 08:10

Constraints for generic tuple types

56248ed

Add regression tests

812b92f

typescript-bot assigned ahejlsberg Apr 5, 2023

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Apr 5, 2023

ahejlsberg requested a review from RyanCavanaugh April 5, 2023 15:12

ahejlsberg added 3 commits April 7, 2023 07:48

More conservative constraints + Constraints in relations

486a88c

Accept new baselines

f5639d7

Add tests

ed4e812

Merge branch 'main' into fix53563

ee429dd

Reinstate conservative constraint logic

417f154

ahejlsberg requested review from DanielRosenwasser and jakebailey May 2, 2023 13:41

jakebailey approved these changes May 2, 2023

View reviewed changes

ahejlsberg merged commit 44f4e27 into main May 2, 2023

ahejlsberg deleted the fix53563 branch May 2, 2023 17:35

This was referenced Jun 2, 2023

TS 5.1.3 Regression: TSC Compiler throws FATAL ERROR: Reached heap limit Allocation failed #54491

Closed

5.1 regression: constraints of generic tuple types are sometimes order-sensitive #54495

Closed

Constraints for generic tuple types #53672

Constraints for generic tuple types #53672

Conversation

ahejlsberg commented Apr 5, 2023 • edited Loading

ahejlsberg commented Apr 5, 2023

typescript-bot commented Apr 5, 2023 • edited Loading

typescript-bot commented Apr 5, 2023 • edited Loading

typescript-bot commented Apr 5, 2023 • edited Loading

typescript-bot commented Apr 5, 2023 • edited Loading

typescript-bot commented Apr 5, 2023 • edited Loading

typescript-bot commented Apr 5, 2023

typescript-bot commented Apr 5, 2023

pmndrs/zustand

tsconfig.json

typescript-bot commented Apr 5, 2023

typescript-bot commented Apr 6, 2023

awerlogus commented Apr 6, 2023

ahejlsberg commented Apr 7, 2023

ahejlsberg commented Apr 7, 2023

typescript-bot commented Apr 7, 2023 • edited Loading

typescript-bot commented Apr 7, 2023 • edited Loading

typescript-bot commented Apr 7, 2023 • edited Loading

typescript-bot commented Apr 7, 2023 • edited Loading

typescript-bot commented Apr 7, 2023

typescript-bot commented Apr 7, 2023

pmndrs/zustand

tsconfig.json

typescript-bot commented Apr 7, 2023

awerlogus commented Apr 12, 2023

ahejlsberg commented Apr 24, 2023

typescript-bot commented Apr 24, 2023 • edited Loading

typescript-bot commented Apr 24, 2023 • edited Loading

typescript-bot commented Apr 24, 2023 • edited Loading

typescript-bot commented Apr 24, 2023 • edited Loading

typescript-bot commented Apr 24, 2023 • edited Loading

typescript-bot commented Apr 24, 2023

typescript-bot commented Apr 25, 2023

typescript-bot commented Apr 25, 2023

vercel/hyper

tsconfig.json

ahejlsberg commented Apr 25, 2023

typescript-bot commented Apr 25, 2023 • edited Loading

typescript-bot commented Apr 25, 2023 • edited Loading

typescript-bot commented Apr 25, 2023 • edited Loading

typescript-bot commented Apr 25, 2023 • edited Loading

typescript-bot commented Apr 25, 2023 • edited Loading

typescript-bot commented Apr 25, 2023

typescript-bot commented Apr 25, 2023

typescript-bot commented Apr 25, 2023

typescript-bot commented Apr 25, 2023

ahejlsberg commented Apr 25, 2023

jcalz commented May 13, 2023 • edited Loading

ahejlsberg commented Apr 5, 2023 •

edited

Loading

typescript-bot commented Apr 5, 2023 •

edited

Loading

typescript-bot commented Apr 5, 2023 •

edited

Loading

typescript-bot commented Apr 5, 2023 •

edited

Loading

typescript-bot commented Apr 5, 2023 •

edited

Loading

typescript-bot commented Apr 5, 2023 •

edited

Loading

typescript-bot commented Apr 7, 2023 •

edited

Loading

typescript-bot commented Apr 7, 2023 •

edited

Loading

typescript-bot commented Apr 7, 2023 •

edited

Loading

typescript-bot commented Apr 7, 2023 •

edited

Loading

typescript-bot commented Apr 24, 2023 •

edited

Loading

typescript-bot commented Apr 24, 2023 •

edited

Loading

typescript-bot commented Apr 24, 2023 •

edited

Loading

typescript-bot commented Apr 24, 2023 •

edited

Loading

typescript-bot commented Apr 24, 2023 •

edited

Loading

typescript-bot commented Apr 25, 2023 •

edited

Loading

typescript-bot commented Apr 25, 2023 •

edited

Loading

typescript-bot commented Apr 25, 2023 •

edited

Loading

typescript-bot commented Apr 25, 2023 •

edited

Loading

typescript-bot commented Apr 25, 2023 •

edited

Loading

jcalz commented May 13, 2023 •

edited

Loading