Skip to content

Fixed a regression with string completions not being available directly in arguments typed using rest parameter #54588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Fixed a regression with string completions not being available directly in arguments typed using rest parameter #54588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/services/stringCompletions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ function getStringLiteralCompletionEntries(sourceFile: SourceFile, node: StringL
// Get string literal completions from specialized signatures of the target
// i.e. declare function f(a: 'A');
// f("/*completion position*/")
return argumentInfo && getStringLiteralCompletionsFromSignature(argumentInfo.invocation, node, argumentInfo, typeChecker) || fromContextualType();
return argumentInfo && getStringLiteralCompletionsFromSignature(argumentInfo.invocation, node, argumentInfo, typeChecker) || fromContextualType(ContextFlags.None);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getStringLiteralCompletionsFromSignature is already using the "inference blocking strategy" so it doesn't make sense (at least usually) for the fallback request~ to use it as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kinda using a simplified approach from the one that I was taking here. So that other PR is also fixing this as is this PR: #54121

}
// falls through (is `require("")` or `require(""` or `import("")`)

Expand Down
9 changes: 9 additions & 0 deletions tests/cases/fourslash/completionsLiteralDirectlyInRestConstrainedToArrayType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/// <reference path="fourslash.ts" />
// @strict: true
////
//// function fn<T extends ('value1' | 'value2' | 'value3')[]>(...values: T): T { return values; }
////
//// const value1 = fn('/*1*/');
//// const value2 = fn('value1', '/*2*/');

verify.completions({ marker: ["1", "2"], includes: [`value1`, `value2`, `value3`] })