Fixed an issue with errors not being correctly reported after completion requests in nested calls #54658
Conversation
…ion requests in nested calls
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
| const containingCallResolvedSignature = containingCall && getNodeLinks(containingCall).resolvedSignature; | ||
| if (containingCall) { | ||
| getNodeLinks(containingCall).resolvedSignature = undefined; | ||
| const cachedSignatures = []; |
There was a problem hiding this comment.
It is important to do this for all signatures on the ancestry path because during completion requests diagnostics are not reported, this is reflected by const reportErrors = !isInferencePartiallyBlocked && !candidatesOutArray; in resolveCall. But if we only restore the result of the inner call (when doing a completion request within its argument) then we might cache the outer signature. That signature might even be correct - but what happens is that when actual diagnostics are requested we don't ever get to checking the inner call because a regular typecheck happens from the top to the bottom and the outer checkCallExpression could just use the cached signature and bail out from reaching the inner checkCallExpression
|
@andrewbranch since this issue is more likely to be observed in 5.1 - what do you think about cherry-picking this into 5.1? :p |
|
I think you should start pinging @DanielRosenwasser directly about that stuff 😅 I was just out on vacation so I don’t know what the current patch status is. |
Fixes an accidental 5.1 regression caused by my own #52717 . Even though this particular situation showcased by the test case is a 5.1 regression, the code that I changed here was likely subtly broken before that - there just wasn't any test case that would catch this somehow.
cc @andrewbranch