-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Transfer all declared symbols onto the type from the interface that extends another #55252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer all declared symbols onto the type from the interface that extends another #55252
Conversation
8f6b733
to
d436316
Compare
@typescript-bot perf test this |
Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at d436316. You can monitor the build here. Update: The results are in! |
@DanielRosenwasser Here they are:
CompilerComparison Report - main..55252
System
Hosts
Scenarios
TSServerComparison Report - main..55252
System
Hosts
Scenarios
StartupComparison Report - main..55252
System
Hosts
Scenarios
Developer Information: |
…signature-on-interface-with-base
@typescript-bot perf test this |
Heya @DanielRosenwasser, I've started to run the regular perf test suite on this PR at 1caae73. You can monitor the build here. Update: The results are in! |
@DanielRosenwasser Here they are:
CompilerComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
StartupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
@typescript-bot test top100 |
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 1caae73. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 1caae73. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 1caae73. You can monitor the build here. Update: The results are in! |
@jakebailey Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
@jakebailey Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Details
|
Aha, that looks like a real failure. |
Hey @jakebailey, the results of running the DT tests are ready. |
Huh, this was fun! The inherited property member from the abstract class had the same name as own type parameter - so |
…signature-on-interface-with-base
@typescript-bot test top200 |
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 31d14c0. You can monitor the build here. |
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 31d14c0. You can monitor the build here. |
@jakebailey Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
@jakebailey Here are some more interesting changes from running the user test suite Details |
Hm, I guess this broke things, somehow. |
@jakebailey ooops, sorry for that! I was juggling PRs and forgot to set |
@typescript-bot test top200 |
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 26cd2f4. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 26cd2f4. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 26cd2f4. You can monitor the build here. |
Well, thanks for testing that our infrastructure actually works and it's not just always saying "looks good" 😄 |
Let's say that was exactly my intention! |
@jakebailey Here are the results of running the top-repos suite comparing Everything looks good! |
Hey @jakebailey, the results of running the DT tests are ready. |
@typescript-bot perf test this |
Heya @jakebailey, I've started to run the regular perf test suite on this PR at 26cd2f4. You can monitor the build here. Update: The results are in! |
@jakebailey Here they are:
CompilerComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
StartupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
…ties Fixes microsoft#56620 Partial revert of microsoft#55252
fixes #55251