Handle default class exports when targeting es6 with non-es6 module kinds #5648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| write(");"); | ||
| } | ||
| else if (modulekind !== ModuleKind.ES6) { | ||
| write(`exports.default = `); |
There was a problem hiding this comment.
in ES3 we should emit this as exports["defualt"]
There was a problem hiding this comment.
Shouldn't this be regular quotation marks? (no embedded variables)
enlight
added a commit
to debugworkbench/hydragon
that referenced
this pull request
Nov 15, 2015
TypeScript 1.8 doesn't correctly transpile default ES6 exports when targeting ES6 + CommonJS. This is a known issue and there's a pending PR to fix it (microsoft/TypeScript#5648). Until then I'm going to make do without default exports.
|
@mhegazy do we want to merge this fix? |
|
👍 |
|
sorry for the delay |
weswigham
added a commit
that referenced
this pull request
Nov 26, 2015
Handle default class exports when targeting es6 with non-es6 module kinds
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5594.