Disallow type predicate as type assertion #5936
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weswigham @ahejlsberg could you take a look since you commented on the original issue. |
| const widenedType = getWidenedType(exprType); | ||
| if (produceDiagnostics) { | ||
| if (node.type.kind === SyntaxKind.TypePredicate) { | ||
| error(node.type, Diagnostics.A_type_predicate_is_not_allowed_as_part_of_a_type_assertion_expression); |
There was a problem hiding this comment.
Rather than creating a new error message, why not call checkTypePredicate, which aught to error here?
There was a problem hiding this comment.
Thanks, I didn't know about that.
|
OK, the change is much smaller now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5731 by disallowing the construction for now.