-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Fix to use string literal type in ArrayBuffer's Symbol.toStringTag
#60150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to use string literal type in ArrayBuffer's Symbol.toStringTag
#60150
Conversation
@typescript-bot test it |
@jakebailey Here are the results of running the user tests with tsc comparing Something interesting changed - please have a look. Details
|
Hey @jakebailey, the results of running the DT tests are ready. There were interesting changes: Changes are too big to display here, please check the log. |
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
@jakebailey Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
I haven't figured it out yet, but maybe we need to update the |
Apparently the package maintainers need to update @types/node. FYI: #58573 (comment) |
@rbuckton IMO, this PR should be included in TypeScript 5.7, but is it possible? |
No, this will need to wait for 5.8 |
@rbuckton Will this PR be included in TypeScript 5.8? |
@typescript-bot test it |
@rbuckton Here are the results of running the user tests with tsc comparing Something interesting changed - please have a look. Details
|
@rbuckton Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
@rbuckton Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
@rbuckton Here are some more interesting changes from running the top 400 repos suite Details
|
@rbuckton Here are some more interesting changes from running the top 400 repos suite Details
|
With the exception of |
This did not make the cut for 5.8, but should be in 5.9. I plan to merge to |
… TS 5.9 due to microsoft/TypeScript#60150 (#26437) microsoft/TypeScript#60150 introduced a breaking change to the type behaviour of string literals and ArrayBuffers. This requires a `@types/node` update to get the latest fixed types from DefinitelyTyped/DefinitelyTyped#70694. We're using `@types/[email protected]` now.
The DT results were too big to display, and I guess that means we might not have noticed them? Seems like DT is quite broken right now. (Note the refs above too). |
Fixes #60149