fix(57026): Renaming on declaration whose name is a String Literal

src/services/findAllReferences.ts

@@ -1013,9 +1013,8 @@ export namespace Core {
         const checker = program.getTypeChecker();
         // constructors should use the class symbol, detected by name, if present
         const symbol = checker.getSymbolAtLocation(isConstructorDeclaration(node) && node.parent.name || node);
-
         // Could not find a symbol e.g. unknown identifier
-        if (!symbol) {
+        if (!symbol || (isStringLiteralLike(node) && isStringLiteralPropertyReference(node, checker))) {
             // String literal might be a property (and thus have a symbol), so do this here rather than in getReferencedSymbolsSpecial.
             if (!options.implementations && isStringLiteralLike(node)) {
                 if (isModuleSpecifierLike(node)) {
@@ -1389,7 +1388,6 @@ export namespace Core {
         /** Only set if `options.implementations` is true. These are the symbols checked to get the implementations of a property access. */
         readonly parents: readonly Symbol[] | undefined;
         readonly allSearchSymbols: readonly Symbol[];
-
         /**
          * Whether a symbol is in the search set.
          * Do not compare directly to `symbol` because there may be related symbols to search for. See `populateSearchSymbolSet`.
@@ -2480,7 +2478,7 @@ export namespace Core {
             cancellationToken.throwIfCancellationRequested();
             return mapDefined(getPossibleSymbolReferenceNodes(sourceFile, node.text), ref => {
                 if (isStringLiteralLike(ref) && ref.text === node.text) {
-                    if (type) {
+                    if (type && !isStringLiteralPropertyReference(node, checker)) {
                         const refType = getContextualTypeFromParentOrAncestorTypeNode(ref, checker);
                         if (type !== checker.getStringType() && (type === refType || isStringLiteralPropertyReference(ref, checker))) {
                             return nodeEntry(ref, EntryKind.StringLiteral);

tests/baselines/reference/renameStringLiteralTypes6.baseline.jsonc

@@ -0,0 +1,9 @@
+// === findRenameLocations ===
+// === /tests/cases/fourslash/renameStringLiteralTypes6.ts ===
+// interface Case_1 {
+//   <|"[|Att 2RENAME|]"/*RENAME*/: string|>
+// }
+// 
+// declare const fnc_1: <K extends keyof Case_1>(p: K) => void
+// 
+// fnc_1("[|Att 2RENAME|]")

tests/baselines/reference/renameStringLiteralTypes7.baseline.jsonc

@@ -0,0 +1,11 @@
+// === findRenameLocations ===
+// === /tests/cases/fourslash/renameStringLiteralTypes7.ts ===
+// declare const Att_1: "[|Att 2RENAME|]"/*RENAME*/
+// 
+// interface Case_1 {
+//   [Att_1]: string
+// }
+// 
+// declare const fnc_1: <K extends keyof Case_1>(p: K) => void
+// 
+// fnc_1("[|Att 2RENAME|]")

tests/baselines/reference/renameStringLiteralTypes8.baseline.jsonc

@@ -0,0 +1,9 @@
+// === findRenameLocations ===
+// === /tests/cases/fourslash/renameStringLiteralTypes8.ts ===
+// type T = {
+//     <|"[|Prop 1RENAME|]"/*RENAME*/: string;|>
+// }
+// 
+// declare const fn: <K extends keyof T>(p: K) => void
+// 
+// fn("[|Prop 1RENAME|]")

tests/cases/fourslash/renameStringLiteralTypes5.ts

@@ -1,11 +1,9 @@
 /// <reference path="fourslash.ts" />
-
 ////type T = {
 ////    "Prop 1": string;
 ////}
 ////
 ////declare const fn: <K extends keyof T>(p: K) => void
 ////
 ////fn("Prop 1"/**/)
-
-verify.baselineRename("", {});
+verify.baselineRename("", {});

tests/cases/fourslash/renameStringLiteralTypes6.ts

@@ -0,0 +1,12 @@
+/// <reference path="fourslash.ts" />
+
+
+////interface Case_1 {
+////  "Att 2"/**/: string
+////}
+////
+////declare const fnc_1: <K extends keyof Case_1>(p: K) => void
+////
+////fnc_1("Att 2")
+
+verify.baselineRename("", {});

tests/cases/fourslash/renameStringLiteralTypes7.ts

@@ -0,0 +1,13 @@
+/// <reference path="fourslash.ts" />
+
+////declare const Att_1: "Att 2"/**/
+////
+////interface Case_1 {
+////  [Att_1]: string
+////}
+////
+////declare const fnc_1: <K extends keyof Case_1>(p: K) => void
+////
+////fnc_1("Att 2")
+
+verify.baselineRename("", {});

tests/cases/fourslash/renameStringLiteralTypes8.ts

@@ -0,0 +1,9 @@
+/// <reference path="fourslash.ts" />
+////type T = {
+////    "Prop 1"/**/: string;
+////}
+////
+////declare const fn: <K extends keyof T>(p: K) => void
+////
+////fn("Prop 1")
+verify.baselineRename("", {});