fix(jsx): correct source location when react-jsx and whitespace before jsx #61534
+42
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e jsx fixes microsoft#61533 the code seemed to be using `node.pos` (`node.getFullStart()`) instead of `node.getStart()`, which caused the source location to be off. now baselines match babel's output (which seems correct). not sure about using `getTokenPosOfNode()` (used by `getStart()`), but didn't find any better way to do things internally.
typescript-bot
added
the
For Uncommitted Bug
original reported issue did not include any fragment, but pattern seems the same, so correct these as well
|
I've applied the same fix for fragments as well, as they seemed to use the same pattern for source location handling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the code seemed to be using
node.pos(node.getFullStart()) instead ofnode.getStart(), which caused the source location to be off.now baselines match babel's output (which seems correct).
not sure about using
getTokenPosOfNode()(used bygetStart()), but didn't find any better way to do things internally.fixes #61533