Unions and intersections of readonly properties are now also readonly #9167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Unions and intersections of the above | ||
| if (symbol.flags & SymbolFlags.SyntheticProperty) { | ||
| return forEach(symbol.declarations, decl => isReadonlySymbol(getSymbolOfNode(decl))); | ||
| } |
There was a problem hiding this comment.
This could probably be more efficient. When a symbol has multiple declarations (such as an overloaded method) we'll end up doing the same check multiple times even though the outcome is always false. Ideally we'd have a SymbolFlags.Readonly that we compute in the same way as SymbolFlags.Optional, but we're out of flag bits. Perhaps it would be better to compute the readonly state in createUnionOrIntersectionProperty (by calling isReadonlySymbol for each underlying symbol) and then record the result in an isReadonly property on the symbol itself.
There was a problem hiding this comment.
That sounds like a good idea. Done.
|
@ahejlsberg can you take a look at the updated code? |
|
👍 |
sandersn
deleted the
make-unions-and-intersections-of-readonly-properties-readonly
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9108
@ahejlsberg can you take a look to confirm that this is how readonly should work with unions and intersections of properties?