Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

allow user to configure jwt connect/read timeout #418

Merged
merged 5 commits into from
Oct 8, 2018
Merged

allow user to configure jwt connect/read timeout #418

merged 5 commits into from
Oct 8, 2018

Conversation

sophiaso
Copy link
Member

Configurable JWT read, connect timeout and size limit

azure.activedirectory.jwt-connect-timeout
azure.activedirectory.jwt-read-timeout
azure.activedirectory.jwt-size-limit

@sophiaso sophiaso force-pushed the configurable-jwt-timeout branch from 19f4875 to 23bf81f Compare September 14, 2018 09:20
@sophiaso sophiaso mentioned this pull request Sep 18, 2018
Closed
@vipinsaini434
Copy link

It is working fine by changing the time limit.

laxmikant4644
laxmikant4644 approved these changes Oct 2, 2018
View reviewed changes
Copy link

@laxmikant4644 laxmikant4644 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to be merged

@sophiaso sophiaso changed the title WIP: allow user to configure jwt connect/read timeout allow user to configure jwt connect/read timeout Oct 3, 2018
@laxmikant4644 laxmikant4644 mentioned this pull request Oct 4, 2018
Closed
Incarnation-p-lee
Incarnation-p-lee approved these changes Oct 8, 2018
View reviewed changes
.../src/main/java/com/microsoft/azure/spring/autoconfigure/aad/AADAuthenticationProperties.java
@@ -38,6 +39,12 @@
@NotEmpty
private List<String> activeDirectoryGroups;

private int jwtConnectTimeout = RemoteJWKSet.DEFAULT_HTTP_CONNECT_TIMEOUT; /* milliseconds */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can file another PR for @Getter.

@sophiaso sophiaso merged commit 6b37c84 into master Oct 8, 2018
@sophiaso sophiaso deleted the configurable-jwt-timeout branch October 8, 2018 01:54
@kai18
Copy link

kai18 commented Jan 7, 2019

Hi @Incarnation-p-lee @laxmikant4644 . Has this change been deployed to the latest available version on maven?

@kai18 kai18 unassigned yaweiw Jan 7, 2019
@Incarnation-p-lee
Copy link
Contributor

@kai18
Thanks for you information. Yes, we have released Azure Spring boot Starters 2.0.8 for spring boot 2.0.x, as well as Azure Spring boot Starters 2.1.0 for spring boot 2.1.x.

@kai18
Copy link

kai18 commented Jan 8, 2019

Ah! Thanks @Incarnation-p-lee . Apparently it was an IDE issue. IntelliJ did not properly index and so couldn't find the properties.

@Incarnation-p-lee
Copy link
Contributor

@kai18
Great! Any other question/issue please feel free to contact us!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laxmikant4644 laxmikant4644 laxmikant4644 approved these changes

@Incarnation-p-lee Incarnation-p-lee Incarnation-p-lee approved these changes

Assignees

@warrenzhu25 warrenzhu25

@Incarnation-p-lee Incarnation-p-lee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sophiaso @vipinsaini434 @kai18 @Incarnation-p-lee @laxmikant4644 @warrenzhu25 @yaweiw