Skip to content

Remove extra semicolons in codebase #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/api/AuthTokensController.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace MAT_NS_BEGIN {

MATSDK_LOG_INST_COMPONENT_CLASS(AuthTokensController, "EventsSDK.AuthTokensController", "Events telemetry client - AuthTokensController class");
MATSDK_LOG_INST_COMPONENT_CLASS(AuthTokensController, "EventsSDK.AuthTokensController", "Events telemetry client - AuthTokensController class")

AuthTokensController::AuthTokensController()
:m_IsStrictModeEnabled(false)
Expand Down
4 changes: 2 additions & 2 deletions lib/api/DataViewerCollection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace MAT_NS_BEGIN {

MATSDK_LOG_INST_COMPONENT_CLASS(DataViewerCollection, "EventsSDK.DataViewerCollection", "Microsoft Telemetry Client - DataViewerCollection class");
MATSDK_LOG_INST_COMPONENT_CLASS(DataViewerCollection, "EventsSDK.DataViewerCollection", "Microsoft Telemetry Client - DataViewerCollection class")

void DataViewerCollection::DispatchDataViewerEvent(const std::vector<uint8_t>& packetData) const noexcept
{
Expand All @@ -21,7 +21,7 @@ namespace MAT_NS_BEGIN {
// Task 3568800: Integrate ThreadPool to IDataViewerCollection
viewer->ReceiveData(packetData);
}
};
}

void DataViewerCollection::RegisterViewer(const std::shared_ptr<IDataViewer>& dataViewer)
{
Expand Down
2 changes: 1 addition & 1 deletion lib/api/DataViewerCollection.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ namespace MAT_NS_BEGIN {

virtual bool IsViewerRegistered(const char* viewerName) const override;

virtual ~DataViewerCollection() noexcept {};
virtual ~DataViewerCollection() noexcept {}
private:
MATSDK_LOG_DECL_COMPONENT_CLASS();

Expand Down
2 changes: 1 addition & 1 deletion lib/api/IRuntimeConfig.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ namespace MAT_NS_BEGIN
/// <returns>Provider Group Id</returns>
virtual const char* GetProviderGroupId() = 0;

virtual ~IRuntimeConfig() {};
virtual ~IRuntimeConfig() {}
};

/// @endcond
Expand Down
12 changes: 6 additions & 6 deletions lib/api/LogManagerImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ namespace MAT_NS_BEGIN
return true;
}

MATSDK_LOG_INST_COMPONENT_CLASS(LogManagerImpl, "EventsSDK.LogManager", "Microsoft Telemetry Client - LogManager class");
MATSDK_LOG_INST_COMPONENT_CLASS(LogManagerImpl, "EventsSDK.LogManager", "Microsoft Telemetry Client - LogManager class")

#if 1
// TODO: integrate Tracing API from v1
Expand Down Expand Up @@ -348,7 +348,7 @@ namespace MAT_NS_BEGIN
client->SetMsRootCheck(m_logConfiguration[CFG_MAP_HTTP][CFG_BOOL_HTTP_MS_ROOT_CHECK]);
}
#endif
};
}

LogManagerImpl::~LogManagerImpl() noexcept
{
Expand Down Expand Up @@ -507,7 +507,7 @@ namespace MAT_NS_BEGIN
const std::string& LogManagerImpl::GetTransmitProfileName()
{
return TransmitProfiles::getProfile();
};
}

ISemanticContext& LogManagerImpl::GetSemanticContext()
{
Expand Down Expand Up @@ -665,7 +665,7 @@ namespace MAT_NS_BEGIN
void LogManagerImpl::AddEventListener(DebugEventType type, DebugEventListener& listener)
{
m_debugEventSource.AddEventListener(type, listener);
};
}

/// <summary>
/// Removes the event listener.
Expand All @@ -675,7 +675,7 @@ namespace MAT_NS_BEGIN
void LogManagerImpl::RemoveEventListener(DebugEventType type, DebugEventListener& listener)
{
m_debugEventSource.RemoveEventListener(type, listener);
};
}

/// <summary>
/// Dispatches the event.
Expand All @@ -685,7 +685,7 @@ namespace MAT_NS_BEGIN
bool LogManagerImpl::DispatchEvent(DebugEvent evt)
{
return m_debugEventSource.DispatchEvent(std::move(evt));
};
}

/// <summary>Attach cascaded DebugEventSource to forward all events to</summary>
bool LogManagerImpl::AttachEventSource(DebugEventSource& other)
Expand Down
2 changes: 1 addition & 1 deletion lib/api/LogManagerImpl.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ namespace MAT_NS_BEGIN
{
const std::string val(value);
return SetContext(name, val, piiKind);
};
}

virtual inline status_t SetContext(const std::string& name, int8_t value, PiiKind piiKind = PiiKind_None) override
{
Expand Down
14 changes: 7 additions & 7 deletions lib/api/Logger.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -170,37 +170,37 @@ namespace MAT_NS_BEGIN
void Logger::SetContext(const std::string& k, const char v[], PiiKind pii)
{
SetContext(k, EventProperty(v, pii));
};
}

void Logger::SetContext(const std::string& k, const std::string& v, PiiKind pii)
{
SetContext(k, EventProperty(v, pii));
};
}

void Logger::SetContext(const std::string& k, double v, PiiKind pii)
{
SetContext(k, EventProperty(v, pii));
};
}

void Logger::SetContext(const std::string& k, int64_t v, PiiKind pii)
{
SetContext(k, EventProperty(v, pii));
};
}

void Logger::SetContext(const std::string& k, time_ticks_t v, PiiKind pii)
{
SetContext(k, EventProperty(v, pii));
};
}

void Logger::SetContext(const std::string& k, GUID_t v, PiiKind pii)
{
SetContext(k, EventProperty(v, pii));
};
}

void Logger::SetContext(const std::string& k, bool v, PiiKind pii)
{
SetContext(k, EventProperty(v, pii));
};
}

// The goal of this method is to rewire the logger instance to any other ISemanticContext issued by SDK.
// SDK may provide a future option for a guest logger to opt-in into its own semantic context. The method will then
Expand Down
10 changes: 5 additions & 5 deletions lib/config/RuntimeConfig_Default.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ namespace MAT_NS_BEGIN
config(customConfig)
{
Variant::merge_map(*customConfig, *defaultRuntimeConfig());
};
}

virtual ~RuntimeConfig_Default()
{
Expand All @@ -125,14 +125,14 @@ namespace MAT_NS_BEGIN
UNREFERENCED_PARAMETER(extension);
UNREFERENCED_PARAMETER(experimentationProject);
UNREFERENCED_PARAMETER(eventName);
};
}

virtual EventLatency GetEventLatency(std::string const& tenantId = std::string(), std::string const& eventName = std::string()) override
{
UNREFERENCED_PARAMETER(tenantId);
UNREFERENCED_PARAMETER(eventName);
return EventLatency_Normal;
};
}

virtual std::string GetMetaStatsTenantToken() override
{
Expand All @@ -144,7 +144,7 @@ namespace MAT_NS_BEGIN
return std::string(token);
}
return std::string(defaultToken);
};
}

virtual unsigned GetMetaStatsSendIntervalSec() override
{
Expand All @@ -154,7 +154,7 @@ namespace MAT_NS_BEGIN
virtual unsigned GetOfflineStorageMaximumSizeBytes() override
{
return config[CFG_INT_CACHE_FILE_SIZE];
};
}

virtual unsigned GetOfflineStorageResizeThresholdPct() override
{
Expand Down
2 changes: 1 addition & 1 deletion lib/decorators/BaseDecorator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace MAT_NS_BEGIN

public:
BaseDecorator(ILogManager& owner);
virtual ~BaseDecorator() {};
virtual ~BaseDecorator() {}
bool decorate(CsProtocol::Record& record);

protected:
Expand Down
2 changes: 1 addition & 1 deletion lib/decorators/EventPropertiesDecorator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ namespace MAT_NS_BEGIN {
//
randomLocalId = "r:";
randomLocalId+= PAL::generateUuidString();
};
}

void dropPiiPartA(::CsProtocol::Record& record)
{
Expand Down
2 changes: 1 addition & 1 deletion lib/decorators/SemanticApiDecorators.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace MAT_NS_BEGIN {
class SemanticApiDecorators : public BaseDecorator {

public:
SemanticApiDecorators(ILogManager& owner) : BaseDecorator(owner) {};
SemanticApiDecorators(ILogManager& owner) : BaseDecorator(owner) {}

bool decorateAggregatedMetricMessage(::CsProtocol::Record& record, AggregatedMetricData const& metricData)
{
Expand Down
2 changes: 1 addition & 1 deletion lib/http/HttpClientFactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

namespace MAT_NS_BEGIN {

MATSDK_LOG_INST_COMPONENT_CLASS(HttpClientFactory, "EventsSDK.HttpClientFactory", "Events telemetry client - HttpClientFactory class");
MATSDK_LOG_INST_COMPONENT_CLASS(HttpClientFactory, "EventsSDK.HttpClientFactory", "Events telemetry client - HttpClientFactory class")

#if defined(MATSDK_PAL_WIN32)
#ifdef _WINRT_DLL
Expand Down
2 changes: 1 addition & 1 deletion lib/http/HttpClientManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ namespace MAT_NS_BEGIN {
// as well pass the data back by updating the data structure.
DebugEvent evt(EVT_HTTP_STATE, size_t(state), 0, data, size);
m_hcm.m_logManager.DispatchEvent(evt);
};
}


virtual ~HttpCallback()
Expand Down
2 changes: 1 addition & 1 deletion lib/http/HttpClient_WinInet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ void HttpClient_WinInet::CancelAllRequests()
PAL::sleep(100);
std::this_thread::yield();
}
};
}

/// <summary>
/// Enforces MS-root server certificate check.
Expand Down
2 changes: 1 addition & 1 deletion lib/include/mat/IDeviceInformation.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace PAL_NS_BEGIN {
{
public:

virtual ~IDeviceInformation() {};
virtual ~IDeviceInformation() {}

/// <summary>
/// Gets the unique ID of the current device
Expand Down
2 changes: 1 addition & 1 deletion lib/include/mat/INetworkInformation.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace PAL_NS_BEGIN {
{
public:

virtual ~INetworkInformation() {};
virtual ~INetworkInformation() {}

/// <summary>
/// Gets the current network provider for the device
Expand Down
2 changes: 1 addition & 1 deletion lib/include/mat/ISystemInformation.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace PAL_NS_BEGIN {
{
public:

virtual ~ISystemInformation() {};
virtual ~ISystemInformation() {}

/// <summary>
/// Gets the App ID.
Expand Down
2 changes: 1 addition & 1 deletion lib/include/public/CAPIClient.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ namespace MAT_NS_BEGIN
{
handle = evt_open(config);
return handle;
};
}

evt_status_t configure(const char* config)
{
Expand Down
2 changes: 1 addition & 1 deletion lib/include/public/CommonFields.h
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,6 @@
virtual void SETTER_METHOD (name) (const std::string & x) \
{ \
SetCommonField(placeholder, x); \
};
}

#endif
6 changes: 3 additions & 3 deletions lib/include/public/DebugEvents.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,12 @@ namespace MAT_NS_BEGIN
size_t size;

/// <summary>DebugEvent The default DebugEvent constructor.</summary>
DebugEvent() : seq(0), ts(0), type(EVT_UNKNOWN), param1(0), param2(0), data(NULL), size(0) {};
DebugEvent() : seq(0), ts(0), type(EVT_UNKNOWN), param1(0), param2(0), data(NULL), size(0) {}

DebugEvent(DebugEventType type) : seq(0), ts(0), type(type), param1(0), param2(0), data(NULL), size(0) {};
DebugEvent(DebugEventType type) : seq(0), ts(0), type(type), param1(0), param2(0), data(NULL), size(0) {}

DebugEvent(DebugEventType type, size_t param1, size_t param2 = 0, void* data = nullptr, size_t size = 0) :
seq(0), ts(0), type(type), param1(param1), param2(param2), data(data), size(size) {};
seq(0), ts(0), type(type), param1(param1), param2(param2), data(data), size(size) {}
};

/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions lib/include/public/IHttpClient.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ namespace MAT_NS_BEGIN
std::ignore = state;
std::ignore = data;
std::ignore = size;
};
}
};

/// <summary>
Expand Down Expand Up @@ -542,7 +542,7 @@ namespace MAT_NS_BEGIN
/// <param name="id">A string that contains the ID of the request to cancel.</param>
virtual void CancelRequestAsync(std::string const& id) = 0;

virtual void CancelAllRequests() {};
virtual void CancelAllRequests() {}
};

/// @endcond
Expand Down
4 changes: 2 additions & 2 deletions lib/include/public/IModule.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ namespace MAT_NS_BEGIN
/// Initializes the module.
/// Invoked as part of parent ILogManager is constructed.
/// </summary>
virtual void Initialize(ILogManager*) noexcept {};
virtual void Initialize(ILogManager*) noexcept {}

/// <summary>
/// Tears down the module.
/// Invoked as part of parent ILogManager's FlushAndTeardown() method.
/// </summary>
virtual void Teardown() noexcept {};
virtual void Teardown() noexcept {}
};

/// @endcond
Expand Down
2 changes: 1 addition & 1 deletion lib/include/public/IOfflineStorage.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ namespace MAT_NS_BEGIN {

virtual bool ResizeDb() = 0;

virtual void ReleaseAllRecords() {};
virtual void ReleaseAllRecords() {}

};

Expand Down
Loading