Skip to content

Add LICENSE/NOTICE.md to sqlcmd install folder #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

stuartpa
Copy link
Collaborator

@stuartpa stuartpa commented Mar 8, 2023

  1. Add LICENSE/NOTICE.md to the install directory on Windows .msi installs (winget/choco)
  2. Add arm/arm64 .msi builds (a separate winget repo PR adds these to the winget installer)
  3. Also, align Architecture naming to winget/brew/debian:

So we will have:

x64 (for Windows/Mac)
amd64 (for Linux)

x86 (for Windows/Mac)
arm (for all Platforms)
arm64 (for all Platforms)

Sources:

https://github.com/jedieaston/winget-cli/blob/0384fcd3657942f59bc94aae3dd888742f9ef632/schemas/JSON/settings/settings.schema.0.2.json#L58

        "enum": [
          "neutral",
          "x64",
          "x86",
          "arm64",
          "arm"
        ],

This also seems to be align with brew:

https://github.com/Homebrew/homebrew-core/blob/361429d75bf64c698c3d971f7aeebe01cedb87c2/Formula/sqlcmd.rb

sha256 cellar: :any_skip_relocation, arm64_ventura:  
sha256 cellar: :any_skip_relocation, arm64_monterey:
sha256 cellar: :any_skip_relocation, arm64_big_sur:  
sha256 cellar: :any_skip_relocation, ventura:        
sha256 cellar: :any_skip_relocation, monterey:       
sha256 cellar: :any_skip_relocation, big_sur:        
sha256 cellar: :any_skip_relocation, x86_64_linux:   

For Debian installers, the choices are:

Available options: amd64,arm64,armel,armhf,i386,mips,mips64el,mipsel,ppc64el,s390x

@stuartpa stuartpa marked this pull request as ready for review March 9, 2023 14:41
@stuartpa stuartpa force-pushed the stuartpa/msi-add-license-notice-file branch from 1c53f99 to fa7d296 Compare March 10, 2023 06:45
@JyotikaGargg JyotikaGargg self-assigned this Mar 10, 2023
@stuartpa stuartpa requested a review from JyotikaGargg March 10, 2023 10:36
@stuartpa stuartpa merged commit b8fed69 into main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants