-
Notifications
You must be signed in to change notification settings - Fork 852
Missing initializationOptions in InitializeParams #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@dbaeumer Thank you! |
kaloyan-raev
added a commit
to kaloyan-raev/vscode
that referenced
this issue
Sep 19, 2016
`InitializeParams.initializationOptions` is optional. See: https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#initialize-request Also it has just been added to the official protocol: microsoft/language-server-protocol#55 Therefore most (if not all) of the clients, other than VSCode, do not currently include the `initializationOptions` in the Initialize Request. In order to be reusable the JSON language server should check if the `initializationOptions` are available before trying to use them.
kaloyan-raev
added a commit
to kaloyan-raev/ls-api
that referenced
this issue
Sep 19, 2016
The `InitializeParams.initializationOptions` has just been added to the protocol: microsoft/language-server-protocol#55
kaloyan-raev
added a commit
to kaloyan-raev/ls-api
that referenced
this issue
Sep 19, 2016
The `InitializeParams.initializationOptions` has just been added to the protocol: microsoft/language-server-protocol#55 Signed-off-by: Kaloyan Raev <[email protected]>
And what content does it hold? |
It is up to the server to specify this. Could be different between different language servers. |
@dbaeumer In VS Code's context, are these user settings? |
No, user settings come via a changeConfiguration notification. |
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The protocol documentation misses the
initializationOptions
member in theInitializeParams
type.The
initializationOptions
member is present in the VSCode language server implementation: https://github.com/Microsoft/vscode-languageserver-node/blob/master/server/src/protocol.ts#L226The text was updated successfully, but these errors were encountered: