[Android] Speech recognition example #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6f340dc.
natke
approved these changes
May 15, 2023
edgchen1
changed the title
wejoncy
approved these changes
May 16, 2023
YUNQIUGUO
approved these changes
May 16, 2023
|
|
||
| // Disable audio buttons first. | ||
| // The stop button will be enabled by the recording task. | ||
| disableAudioButtons() |
There was a problem hiding this comment.
wondering why do we need this "disable" state handling of the audio button?
There was a problem hiding this comment.
since pressing this button starts some work in another thread, I didn't want to allow it to be pressed again before the recording is done and have to worry about keeping state consistent.
| return OnnxTensor.createTensor(env, FloatBuffer.wrap(data), shape) | ||
| } | ||
|
|
||
| internal fun tensorShape(vararg dims: Long) = longArrayOf(*dims) |
There was a problem hiding this comment.
Good to know there's a vararg keyword in kotlin.
assuming it is safe to pass in zero elements and also only works for the same type series of arguments?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add speech recognition example for Android using Whisper model.
Thanks @MaanavD for help with the UI.