Add basic iOS phi-3 sample #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skottmckay
reviewed
Jun 6, 2024
skottmckay
reviewed
Jun 7, 2024
Co-authored-by: Scott McKay <[email protected]>
skottmckay
reviewed
Jun 7, 2024
edgchen1
reviewed
Jun 7, 2024
skottmckay
reviewed
Jun 7, 2024
skottmckay
reviewed
Jun 7, 2024
|
|
||
| Usually the build output path for libonnxruntime.dylib is under `<ORT_PROJECT_ROOT>/build/intermediates/<platform>_<arch>/<build_config>/<build_config-platform>/libonnxruntime.dylib` and the build output path for libonnxruntime-genai.dylib is under `<ORT_GENAI_PROJECT_ROOT>/build/<build_config-platform>/libonnxruntime-genai.dylib`. For example: | ||
| it may look like: `onnxruntime/build/intermediates/iphoneos_arm64/Release/Release-iphoneos/libonnxruntime.1.19.0.dylib` | ||
| and similarly `onnxruntime-genai/build/Release/Release-iphoneos/libonnxruntime-genai.dylib`. |
There was a problem hiding this comment.
nit: We need to fix the genai ios build to include the architecture in the output path.
There was a problem hiding this comment.
right good catch.. - forgot how xcode generate those path, but possibly a build variable is not correctly read for "ARCHS"
Co-authored-by: Scott McKay <[email protected]>
edgchen1
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a basic iOS Phi-3 sample application, achieves the functionality of generating streaming output token by token in the app similarly as for the android Phi-3 app.
TODOs:
Partially referenced from this project: https://github.com/Azure-Samples/Phi-3MiniSamples/tree/main/ios