Phi 3 Android app Update #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgchen1
reviewed
Sep 24, 2024
mobile/examples/phi-3/android/app/src/main/java/ai/onnxruntime/genai/demo/MainActivity.java
Outdated
Show resolved
Hide resolved
edgchen1
reviewed
Sep 24, 2024
mobile/examples/phi-3/android/app/src/main/java/ai/onnxruntime/genai/demo/BottomSheet.java
Show resolved
Hide resolved
skottmckay
reviewed
Sep 26, 2024
| private static final String TAG = "genai.demo.MainActivity"; | ||
| private int maxLength = 100; | ||
| private int lengthPenalty = 1000; |
There was a problem hiding this comment.
According to this doco the default for length penalty is 1, with values < 1 encouraging shorter responses and > 1 longer. Is that doco out of date? Or if not, should this be a float and start at 1.0?
There was a problem hiding this comment.
Can we add info on the new configuration params and a link to the genai doco for them? 'length penalty' is somewhat obtuse.
mobile/examples/phi-3/android/app/src/main/java/ai/onnxruntime/genai/demo/MainActivity.java
Show resolved
Hide resolved
Comment on lines
172
to
173
| Log.i(TAG, "Prompt processing time (first token): " + (firstTokenTime - startTime)/ 1000.0 + " seconds"); | ||
| Log.i(TAG, "Tokens generated per second (excluding prompt processing): " + 1000 * ((numTokens -1) / totalTime)); |
There was a problem hiding this comment.
Would it be much work to add a setting for 'display timing' and if true we add this info at the end of the response that is displayed to the user?
There was a problem hiding this comment.
added small pop up that shows the rates after prompt generation is done
skottmckay
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Phi-3 Android app