Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'tuple' object has no attribute 'to_dict' for bert #512

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahsan-ca
Copy link

Fixes: AttributeError: 'tuple' object has no attribute 'to_dict' for bert

@ahsan-ca ahsan-ca force-pushed the fix-dict-error-bert branch 2 times, most recently from 10fe66c to 65f5a27 Compare March 25, 2025 19:05
@ahsan-ca ahsan-ca force-pushed the fix-dict-error-bert branch from 65f5a27 to 1b1f672 Compare March 25, 2025 21:55
Copy link

@causten causten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated in ROCm MIGXEP

@TedThemistokleous
Copy link
Contributor

ping @tianleiwu need this as we're leveraging your examples for testing

@tianleiwu tianleiwu enabled auto-merge (squash) April 7, 2025 04:27
@ahsan-ca
Copy link
Author

ahsan-ca commented Apr 7, 2025

@tianleiwu Please don't merge this at this time, while this code fixes the issue of AttributeError: 'tuple' object has no attribute 'to_dict', we just discovered a memory access issue with this that needs to be fixed as well.
I will ping here once I update the changes with the fix. Thanks!
FYI @TedThemistokleous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants