Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] DLLs in maven build are not digitally signed #19204

Open
christophvw opened this issue Jan 19, 2024 · 1 comment
Open

[Build] DLLs in maven build are not digitally signed #19204

christophvw opened this issue Jan 19, 2024 · 1 comment
Assignees
@idiskyle
Labels
build build issues; typically submitted using template platform:windows issues related to the Windows platform

Comments

@christophvw
Copy link

Describe the issue

DLLs in maven build are not digitally signed.

https://repo1.maven.org/maven2/com/microsoft/onnxruntime/onnxruntime/1.16.3/

extract [onnxruntime-1.16.3.jar] (https://repo1.maven.org/maven2/com/microsoft/onnxruntime/onnxruntime/1.16.3/onnxruntime-1.16.3.jar)

Browse to onnxruntime-1.16.3\ai\onnxruntime\native\win-x64

View properties of onnxruntime.dll and onnxruntime4j_jni.dll -> the files are not signed

Urgency

We cannot run unsigned DLLs from user writeable folders.

Target platform

Windows

Build script

.

Error / output

.

Visual Studio Version

No response

GCC / Compiler Version

No response
@christophvw christophvw added the build build issues; typically submitted using template label Jan 19, 2024
@github-actions github-actions bot added the platform:windows issues related to the Windows platform label Jan 19, 2024
@snnn snnn self-assigned this Jan 22, 2024
@snnn
Copy link
Member

snnn commented Jul 8, 2024

I can confirm the problem still exists.

@snnn snnn assigned idiskyle and unassigned snnn Sep 12, 2024
@idiskyle idiskyle mentioned this issue Oct 11, 2024
Merged
snnn pushed a commit that referenced this issue Oct 11, 2024
@idiskyle
Add Digital Signature to DLLs in Maven Build (#22401)

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
GPG key ID: 9F6A681E35EF8B56
Verified
Learn about vigilant mode
Loading
Loading status checks…
cdebf37 
### Description
* Add digital signature to dll files in jar files.
* Jar file names: onnxruntime-{version}.jar,
onnxruntime_gpu-{version}.jar

### Motivation and Context
#19204
guschmue pushed a commit that referenced this issue Oct 18, 2024
@idiskyle @guschmue
Add Digital Signature to DLLs in Maven Build (#22401)
eaba679 
### Description
* Add digital signature to dll files in jar files.
* Jar file names: onnxruntime-{version}.jar,
onnxruntime_gpu-{version}.jar

### Motivation and Context
#19204
ishwar-raut1 pushed a commit to ishwar-raut1/onnxruntime that referenced this issue Nov 19, 2024
@idiskyle
Add Digital Signature to DLLs in Maven Build (microsoft#22401)
9219062 
### Description
* Add digital signature to dll files in jar files.
* Jar file names: onnxruntime-{version}.jar,
onnxruntime_gpu-{version}.jar

### Motivation and Context
microsoft#19204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idiskyle idiskyle

Labels
build build issues; typically submitted using template platform:windows issues related to the Windows platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@snnn @christophvw @idiskyle