Dynamically load ort-wasm*.js according to the EP name #19130
Conversation
In wasm-factory.ts file, if the BUILD_DEFS.DISABLE_WEBGPU is false, it will laod ort-wasm*.jsep.js by default, which would cause other ep (e.g. webnn ep) fail in npm test if it is not compiled in the ort-wasm*.jsep.js. This PR is intent to dynamically load the ort-wasm*.js ccording to the ep name.
| @@ -17,7 +17,7 @@ if (!BUILD_DEFS.DISABLE_TRAINING) { | |||
| BUILD_DEFS.DISABLE_WEBGPU ? require('./binding/ort-wasm.js') : require('./binding/ort-wasm-simd.jsep.js'); | |||
| } | |||
|
|
|||
| const ortWasmFactoryThreaded: EmscriptenModuleFactory<OrtWasmModule> = !BUILD_DEFS.DISABLE_WASM_THREAD ? | |||
| let ortWasmFactoryThreaded: EmscriptenModuleFactory<OrtWasmModule> = !BUILD_DEFS.DISABLE_WASM_THREAD ? | |||
There was a problem hiding this comment.
@fs-eire, I was trying to move the code of ortWasmFactory and ortWasmFactory initialization to the initializeWebAssembly function, but failed.
Looks like it takes some other ort-web initialization work in somewhere. Is that possible to optimize them?
There was a problem hiding this comment.
The initialization logic is kind of complicated. You can check #18715 for details if you are interested.
|
@Honry I think you are going to use the ort-wasm*.jsep.wasm for webnn soon. The real reason why we split the web assembly artifacts into 2 versions (ort-wasm*.wasm and ort-wasm*.jsep.wasm) is because in JSEP we use ASYNCIFY, which significantly increased the binary size. We have customers only interested in CPU with tiny models, and they care about the binary size, so we keep the old wasm build without asyncify and add the ".jsep" to the file name for new builds. I saw that you are working on introducing ASYNCIFY into webNN, so I guess the easiest way is to stick with ort-wasm*.jsep.wasm, unless you have a special requirement to exclude WebGPU from your build. @guschmue is working on enabling webnn on JSEP and I think that is almost done. And I am a little confused about why it added "BUILD_DEFS.DISABLE_WEBNN" in #18486. The BUILD_DEFS is introduced only for trimming down the generated JS file size (for example, ort.wasm.min.js will not contain webgl/webgpu JS code, so it became much smaller), but we have almost no JS code for WebNN. It does not affect how the corresponding wasm files are built. |
Oh, really? If binary size is not a problem for WebNN EP, we can remove |
In wasm-factory.ts file, if the BUILD_DEFS.DISABLE_WEBGPU is false, it will load the ort-wasm*.jsep.js by default, which would cause other ep (e.g. webnn ep) fail in npm test if it is not compiled in the ort-wasm*.jsep.js. This PR is intent to dynamically load the ort-wasm*.js according to the ep name.