This repository was archived by the owner on Jan 31, 2023. It is now read-only.
Work around old-style constructors in PGO training case #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class.php of the pgo01org training case still uses PHP 4 style constructors, which trigger deprecation notices and as such may negatively affect the optimization. Until this will be fixed upstream, we're employing the workaround to modify the file during the PGO initialization step.
|
Merged, thanks! Btw. no need to mention pr in the code, instead you could put Thanks. |
|
Ups, Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
class.php of the pgo01org training case still uses PHP 4 style
constructors, which trigger deprecation notices and as such may
negatively affect the optimization. Until this will be fixed upstream,
we're employing the workaround to modify the file during the PGO
initialization step.