This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Fix invalid insertTextFormat in CompletionItem instances #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -146,6 +146,7 @@ await InvokeExtensionsAsync((ext, token) | |||
| filterText = x.filterText, | |||
| preselect = x.preselect, | |||
| insertText = x.insertText, | |||
| insertTextFormat = (PythonTools.Analysis.LanguageServer.InsertTextFormat)x.insertTextFormat, | |||
There was a problem hiding this comment.
using? Definitions that are in the engine are obsolete and are kept around for backward compat. POR to remove them in a month or so.
There was a problem hiding this comment.
I'm not sure if any of that is used, but I wanted to be thorough and make sure it's set anywhere it can be. Once all of the old types go away this'll probably also be deleted (and we can probably start setting sane defaults too).
MikhailArkhipov
approved these changes
Nov 5, 2018
jakebailey
added a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
* fix invalid insertTextFormat in CompletionItem instances * check insertTextFormat in AssertCompletion, defaulted to PlainText * only check items which are in contains for format matching, not all
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342.
All places where
insertTextis set,insertTextFormatis now also set. Tests which checkinsertTextdirectly also now checkinsertTextFormat. Most tests use AssertCompletion, which I have modified to also check that every matching completion has a specific format. VS complains about the tuple because I usedItem#instead of an inferred name to access it, which I'd like to do but cannot because this project seems to only be on C# 7.0, not 7.1.I think it would be better for the classes that use these sorts of enums to explicitly define the default value (especially given so many LSP enums do not contain 0), but there are quite a few enums and a load of duplication in the two Structures.cs files that I'm not going to try to attempt it now.