Skip to content

Avoid changing layout if the panel is already visible #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Avoid changing layout if the panel is already visible #2344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion vscode/src/webviewPanel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,13 @@ export class QSharpWebViewPanel {
}

reveal(column: ViewColumn) {
this.panel.reveal(column, true);
// If it's already visible, don't do anything else it messes up the existing layout
// This isn't perfect, as if the tab is just in the background it will still call
// reveal to bring to the foreground and change the layout, but this is the best we
// can do with the current API.
if (!this.panel.visible) {
this.panel.reveal(column, true);
}
}

private _getWebviewContent(webview: Webview) {
Expand Down
Loading