Skip to content

Enable the CLI to create a C++/WinRT native module library that consumes Microsoft.ReactNative #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks
jonthysell opened this issue Sep 24, 2019 · 3 comments · Fixed by #5921
Closed
4 tasks

Enable the CLI to create a C++/WinRT native module library that consumes Microsoft.ReactNative #3203

jonthysell opened this issue Sep 24, 2019 · 3 comments · Fixed by #5921
Assignees
@jonthysell
Labels
Area: CLI
Milestone
Backlog

Comments

@jonthysell
Copy link
Contributor

jonthysell commented Sep 24, 2019 •
edited
Loading

Project should be set up similar to the SampleLibraryCPP sample:

  • C++/WinRT component library
  • Depends only on Microsoft.ReactNative and Microsoft.ReactNative.Cxx
  • Provides a ReactPackageProvider that automatically includes all native modules, and view managers
  • Provides a simple sample native module
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Sep 24, 2019
@jonthysell jonthysell added this to the vNext Milestone 3 milestone Sep 24, 2019
@jonthysell jonthysell removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Sep 24, 2019
@jonthysell jonthysell self-assigned this Sep 24, 2019
@jonthysell
Copy link
Contributor Author

Stretch goal for M3, possibly move to M4.

@namrog84
Copy link
Contributor

namrog84 commented Nov 1, 2019

This sounds super awesome! We currently have about 15 native packages/modules inside our main app's project and would love an easier time creating new libraries for each one and pull them out properly.

@jonthysell
Copy link
Contributor Author

Potentially considering putting this in @brodybits/create-react-native-module, rather than our own CLI.

@jonthysell jonthysell mentioned this issue Nov 8, 2019
Closed
@chrisglein chrisglein removed the vnext label Mar 18, 2020
@jonthysell jonthysell modified the milestones: 0.62 (M5), 0.63 (M6) Apr 10, 2020
@mjfusa mjfusa mentioned this issue Jul 1, 2020
Closed
@chrisglein chrisglein modified the milestones: 0.63, Backlog Jul 13, 2020
@jonthysell jonthysell mentioned this issue Sep 4, 2020
Merged
jonthysell added a commit to jonthysell/react-native-windows that referenced this issue Sep 11, 2020
@jonthysell
Adding new native module template support to react-native-windows-init
b8dc961 
This PR extends `react-native-windows-init` with a `--projectType
[app|lib]` option and a set of new native module lib templates for both
C++ and C#. This provides a much needed mechanism for developers wishing
to add windows implementation to an existing native module (esp.
community modules) without having to set up the VS files manually.

Closes microsoft#3203
Closes microsoft#3201
@ghost ghost added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Sep 16, 2020
jonthysell added a commit that referenced this issue Sep 18, 2020
@jonthysell
Add new native module template support to react-native-windows-init (#…
c7a42af 
…5921)

This PR extends `react-native-windows-init` with a `--projectType [app|lib]` option and a set of new native module lib templates for both C++ and C#. This provides a much needed mechanism for developers wishing to add windows implementation to an existing native module (esp. community modules) without having to set up the VS files manually.

Closes #3203 
Closes #3201
@jonthysell jonthysell removed the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonthysell jonthysell

Labels
Area: CLI
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add new native module template support to react-native-windows-init jonthysell/react-native-windows
3 participants
@namrog84 @jonthysell @chrisglein