-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix react devtools hitting an assert on launch #14320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
acoates-ms
approved these changes
Jan 31, 2025
TatianaKapos
added a commit
to TatianaKapos/react-native-windows
that referenced
this pull request
Jan 31, 2025
TatianaKapos
added a commit
to TatianaKapos/react-native-windows
that referenced
this pull request
Jan 31, 2025
TatianaKapos
added a commit
to TatianaKapos/react-native-windows
that referenced
this pull request
Jan 31, 2025
TatianaKapos
added a commit
that referenced
this pull request
Jan 31, 2025
TatianaKapos
added a commit
that referenced
this pull request
Feb 1, 2025
TatianaKapos
added a commit
that referenced
this pull request
Feb 1, 2025
acoates-ms
pushed a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Mar 11, 2025
* ignore unsupported methods * delete Super::DispatchCommand call * Change files
acoates-ms
added a commit
that referenced
this pull request
Mar 12, 2025
* Update Guardrails on Provider Instantiation (#13961) * Update Provider Guardrails * Change files * Format * Update Snapshots * Use WebSocket factory in PkgInspectorConnection (#14202) * Use WebSocket resource factory for pkgr inspector * Change files * clang format * Implement ISelectionProvider and ISelectionItemProvider (#14019) Adds support for ISelectionProvider interface Adds support for ISelectionItemProvider interface Adds support for accessibilityState:selected Adjusts AccessibilityState native type on Windows to be std::optional instead of bool Adjusts AccessibilityState native type on Windows to include multiselectable and required fields of type std::optional Adds multiselectable and required fields to AccessibilityState type in JS with type boolean | undefined Adds support for aria-multiselectable and aria-required. Adds support for the following accessibilityActions: addToSelection, removeFromSelection, select Fixes crash in AccessibilityInsights. * [Fabric] Implement IRangeValueProvider and Adjust IValueProvider Implementation (#14212) * IRangeValue Provider * Adjust ReadOnly to Use Prop Value * Complete IRangeValueProvider Implementation * Change files * Update Snapshots * std::aligned_storage is deprecated (#14253) * std::aligned_storage is deprecated * Change files * format --------- Co-authored-by: Andrew Coates <[email protected]> * Update WinUI3ExperimentalVersion from 1.6.240701003-experimental2 to 1.7.250109001-experimental2 (#14270) * Update WinUI3ExperimentalVersion from 1.6.240701003-experimental2 to 1.7.250109001-experimental2 * Change files * Update some type and method names that have changed in WinAppSDK 1.7 --------- Co-authored-by: Jon Thysell <[email protected]> * Rework modal to be implemented entirely using public APIs (#14256) * Rework modal implementation to use public APIs * shutdown fix * Change files * format * remove dead code * format * fixes * fix * UIA tree for root component should be kept distinct from main UIA tree * input offset fix for sub rootviews * Split modal into two componentview's so that we dont have multiple roots in our componentview tree * format * Ensure rootview removes itself from the island, before a new one adds itself on instance reload * defork some modal test pages * remove override * Enable basic XamlIsland in rntester within playground app when UseExperimentalWinUI3 is true (#14272) * Enable basic XamlIsland in rntester within playground app when UseExperimentalWinUI3 is true * Change files * Fix build break due to unreferenced parameter * lint * Move the implementation of CalendarView to sample-custom-component, and use codegen * Enable CalendarView only when UseExperimentalWinUI3 is true, and add CalendarView.g.h to git * clang format * Update snapshots and remove some unused variables * Update snapshotPages.test.js.snap * Remove new page from the visitAllPages test * Remove Paper-only code from Fabric builds of Microsoft.ReactNative (#14289) Removes most of the Paper-only code from Fabric builds of Microsoft.ReactNative. This is only a first pass - there may be more that needs to be removed (or stuff that needs to be put back in). - Bug fix (non-breaking change which fixes an issue) - Breaking change (fix or feature that would cause existing functionality to not work as expected) Besides nearly doubling the size of the binary files, all of the Paper-only code is functionally useless in Fabric builds, which at worse is dead weight, and at best is confusing to developers. Resolves #13405 Updated project files to not load/compile paper-only modules. Updated modules that are used by both to correctly only include the Paper or Fabric code they need. None, but here are some preliminary binary size numbers for x64 release: | File | Paper | Fabric (Before) | Fabric (After) | |:-|:-:|:-:|:-:| | Microsoft.ReactNative.dll | 4.02 MB | 8.32 MB | 6.47 MB (🔻1.85 MB / 22% ) | | Microsoft.ReactNative.winmd | 64.0 KB | 121.0 KB | 92.0KB (🔻29 KB / 24%) | Verified all existing tests still pass and fabric apps work. Should this change be included in the release notes: _yes_ Remove Paper-only code from Fabric builds of Microsoft.ReactNative * RNIsland UIA fragment root should report parents fragment root (#14302) * Fix crash running on server 2016 * RNIsland UIA fragment root should report parents fragment root * Change files * fix * use react tag for runtime id * fix * fix * fix * Fix crash when currently focused element gets marked as enableFocusRing=false (#14306) * Fix crash when currently focused element gets marked as enableFocusRing=false * Change files * [Fabric] Add Functional Tests for Switch Component (#14297) * Add Functional Tests for Switch * Fix Tests * Update Snapshots * [Fabric] Use PopupWindowSiteBridge for Modal when USE_EXPERIMENTAL_WINUI3 is true (#14284) * add modal implementation with PopupWindowSiteBridge * Change files * add conditional * feedback * Initial support for UIA and tab navigation for a child Island (#14305) * Basic support for stitching the UIA tree for a ContentIslandComponentView's child * Updated comment * Change files * Support shift+tab, and move Automation event handlers to ContentIslandComponentView * Allow portals to have independent layout constraints and scale factor (#14315) * Allow portals to have independent layout constraints and scale factor * format * change files * fix * Round Focus visuals by default, fix nudge rendering (#14312) * Round Focus visuals by default, fix nudge rendering * Change files * Only build OfficeReact.Win32 with UseFabric enabled (#14319) This PR changes our build system to only build the version of `OfficeReact.Win32` with Fabric enabled. - Breaking change (fix or feature that would cause existing functionality to not work as expected) We are building both versions of Desktop in our CI, but the `-Fabric` version is in fact a strict superset of functionality and the only one that Office uses now. Changed the default so that Desktop always builds with `RnwNewArch` (and therefore `UseFabric`) enabled. Removed the matrix configurations for DesktopFabric from all CI. Fixed the affected nuspec file. Also fixed Desktop publish to include ARM64EC for Fabric and the an issue caused by #14311. N/A. Verified the build works. Should this change be included in the release notes: _no_ * Fix react devtools hitting an assert on launch (#14320) * ignore unsupported methods * delete Super::DispatchCommand call * Change files * [Fabric] Fix PlatformColor (#14325) * Fix platform color * Change files * Add missing theme colors * snapshots * TurboModule spec checking should accept hstring for string arguments (#14322) * TurboModule spec checking should accept hstring for string arguments * Change files * example * [Fabric] Add Support for ITextProvider, ITextProvider2, and ITextRangeProvider (#14332) * Partial Implementation * Add More Implementation * More Implementation * More Implementation * Add Support for Bounding Rectangles * Complete Initial Implementation * Change files * Code Cleanup * Code Cleanup * Update Snapshots + Code Cleanup * Update Snapshots * Address Feedback * Address Feedback * Update Snapshots * Fix Tests --------- Co-authored-by: Jon Thysell <[email protected]> * [Fabric] Fix modal height (#14343) * fix modal height * Change files * reverse change * add override * Fix stale focus rects left in UI when last focusable component is removed (#14359) * Fix stale focus rects left in UI when last focusable component is removed * Change files --------- Co-authored-by: Tatiana Kapos <[email protected]> * Fix issue when calling arrange on an RN Island during load (#14362) * Fix issue when calling arrange on an RN Island during load * Change files --------- Co-authored-by: Tatiana Kapos <[email protected]> * Fix tooltips in high dpi (#14397) * Fix tooltips in high dpi * Change files * format * tooltips dont respect textscalefactor * Fix build issue building component codegen using clang (#14393) * Fix build issue building component codegen using clang * Change files * Components do not lose hover state if pointer leaves window before it leaves the component (#14375) * Components do not lost hover state if pointer leaves window before it leaves the component * format * Change files --------- Co-authored-by: Tatiana Kapos <[email protected]> * Property updates switching between PlatformColors would no-op (#14398) * Property updates switching between PlatformColors would no-op * Change files * format * [Fabric] Add Support for Role Prop (#14352) * Add Support for Role Prop * Change files * Format * Update Tests --------- Co-authored-by: Tatiana Kapos <[email protected]> * Fix bool operator on transparent colors returning false (#14413) * Fix crash loading logbox * Fix bool operator on transparent colors returning false * Change files * format * change files * codegen updates * update overrides * snapshots --------- Co-authored-by: Chiara Mooney <[email protected]> Co-authored-by: Julio César Rocha <[email protected]> Co-authored-by: Tiago <[email protected]> Co-authored-by: JesseCol <[email protected]> Co-authored-by: Jon Thysell <[email protected]> Co-authored-by: Tatiana Kapos <[email protected]>
acoates-ms
pushed a commit
to acoates-ms/react-native-windows
that referenced
this pull request
May 29, 2025
* ignore unsupported methods * delete Super::DispatchCommand call * Change files
acoates-ms
added a commit
that referenced
this pull request
May 30, 2025
* Initial support for UIA and tab navigation for a child Island (#14305) * Basic support for stitching the UIA tree for a ContentIslandComponentView's child * Updated comment * Change files * Support shift+tab, and move Automation event handlers to ContentIslandComponentView * Allow portals to have independent layout constraints and scale factor (#14315) * Allow portals to have independent layout constraints and scale factor * format * change files * fix * Round Focus visuals by default, fix nudge rendering (#14312) * Round Focus visuals by default, fix nudge rendering * Change files * Fix react devtools hitting an assert on launch (#14320) * ignore unsupported methods * delete Super::DispatchCommand call * Change files * [Fabric] Fix PlatformColor (#14325) * Fix platform color * Change files * Add missing theme colors * snapshots * TurboModule spec checking should accept hstring for string arguments (#14322) * TurboModule spec checking should accept hstring for string arguments * Change files * example * Fix Number.h not copied from react-native core (#14331) ## Description ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why react-native-windows currently maintains its own forked C++ TurboModule bridging files. For untouched stuff we copy JSI and TurboModule files from core react-native in `Layout-MSRN-Headers.ps1`. However, this script misses to copy `Number.h`. This causes compilation error when trying to import `react/bridging/Bridging.h`, which would be the case for example when using codegen to generate C++ TurboModule (JSI) bindings (note: this is for C++ JSI TurboModules, not react-native-windows's TurboModule system). ``` PS C:\Users\CocoT1\Projects\rn77> yarn example windows [...] Time Elapsed 00:00:00.61 ✔ Restoring NuGet packages ✔ Auto-linking... Success: No auto-linking changes necessary. (69ms) ✔ Found Solution: C:\Users\CocoT1\Projects\rn77\example\windows\rn77Example.sln ℹ Build configuration: Debug ℹ Build platform: x64 ✖ Building Solution: Generating Code... ✖ Build failed with message 4:7>C:\Users\CocoT1\.nuget\packages\microsoft.reactnative.cxx\0.77.0-fabric\tools\Microsoft.ReactNative.Cxx\ReactCommon\react\bridging\Bridging.h(18,10): error C1083: Cannot open include file: 'react/bridging/Number.h': No such file or directory [C:\Users\CocoT1\Projects\rn77\example\windows\rn77Example\rn77Example.vcxproj]. Check your build configuration. ``` ### What I'm changing the `Layout-MSRN-Headers.ps1` script to also copy `Number.h`. I think this should be enough for the nuget the contain to file, but I'm no expert here. ## Testing Monkeypatched by copying over Number.h to the microsoft.reactnative.cxx nuget (`C:\Users\CocoT1\.nuget\packages\microsoft.reactnative.cxx\0.77.0-fabric\tools\Microsoft.ReactNative.Cxx\ReactCommon\react\bridging\`). Works all good. I don't know how to run the `Layout-MSRN-Headers.ps1` script locally. Here's a create-react-native-library project: https://github.com/hsjoberg/rnw-cxx-turbomodule Note: it will fail to build unless you copy Number.h over to the nuget cache as explained earlier. * Fix stale focus rects left in UI when last focusable component is removed (#14359) * Fix stale focus rects left in UI when last focusable component is removed * Change files --------- Co-authored-by: Tatiana Kapos <[email protected]> * Fix issue when calling arrange on an RN Island during load (#14362) * Fix issue when calling arrange on an RN Island during load * Change files --------- Co-authored-by: Tatiana Kapos <[email protected]> * Fix tooltips in high dpi (#14397) * Fix tooltips in high dpi * Change files * format * tooltips dont respect textscalefactor * Fix build issue building component codegen using clang (#14393) * Fix build issue building component codegen using clang * Change files * Components do not lose hover state if pointer leaves window before it leaves the component (#14375) * Components do not lost hover state if pointer leaves window before it leaves the component * format * Change files --------- Co-authored-by: Tatiana Kapos <[email protected]> * Property updates switching between PlatformColors would no-op (#14398) * Property updates switching between PlatformColors would no-op * Change files * format * Fix bool operator on transparent colors returning false (#14413) * Fix crash loading logbox * Fix bool operator on transparent colors returning false * Change files * format * [Fabric] Implement textAlign prop in TextInput (#14407) * Introduce support for textAlign * Add playground textinputs demonstrating textAlign * Oops, let's remove textAlignOnUpdateProps * Change files * Lint fixes * Nit * Make textAlign to be of facebook::react::TextAlignment type * Lint fixes * Don't reinvent the wheel :D * Nit: yarn format * [Fabric] Allow text components to have children (#14438) * get images/views inline with text on fabric * add back in comments * Change files * remove duplicate code * add baseline for textinput * add checks for paper vs fabric * try fixing image * add resize:none and tests * fix override * comment out test * fix tests * fix typo * try to fix tests * comment out text test * mark windows-specific changes * Allow TextInput to scroll (#14448) * Allow TextInput to scroll * Change files * update snapshot * Implement onScrollBeginDrag property for ScrollView for fabric (#14446) Implement onScrollBeginDrag property for ScrollView for fabric (#14446) * [Fabric] Implement letterSpacing for TextInput (#14460) * Implement letterSpacing for TextInput * Change files * Update react-native-windows-9ee8d633-698c-476d-9334-170be2c5dc25.json * Update textinput.tsx * optimize code * Added tooltip property for Text (#14470) * Added tooltip property in Text.windows.js TextProps.windows.js for typescript to recognise it as an attribute of Text component * Added override Text.d.ts to src-win/Libraries/Text/ to add tooltip prop to Text component * Change files * Added Sample/text for tooltip prop tests * Added TextPropsWindows to include windows specific prop tooltip * updated TextProps interface to extednd TextPropsWindows * lint fix for Sample/text.tsx file --------- Co-authored-by: Abhijeet Jha <[email protected]> * [Fabric] Add Custom Font Family in Text Input (#14495) * [Fabric] Fix Bug in Narrator Navigation (#14498) * Fix Narrator Bug * Change files * Revert Codegen Changes * Implemented on onEndEditing for TextInput component (#14489) * implemented on onEndEditing * Change files * Update textinput.tsx to remove keyboard=dismiss which actually will cause blur or lost focus implicitly * lint fixes * updated legacy textInput snapshot for component update --------- Co-authored-by: Abhijeet Jha <[email protected]> * [Fabric] Add ImageRequestParams for Image Component (#14494) * [Fabric] Implement onProgress for Image (#14493) * [Fabric] Implement SpellCheck and AutoCorrect for TextInput (#14509) * Textinput double clicking selects text (#14515) * added check for double click on textInput component view connecting it to WM_LBUTTONDBLCLK * Change files * updated for lint fix * updated to remove position( Distance check) --------- Co-authored-by: Abhijeet Jha <[email protected]> * [Fabric] Implement decelerationRate in ScrollView (#14528) * [Fabric] Implement showsVerticalScrollIndicatorValue and showsHorizontalScrollIndicatorValue for ScrollView (#14526) * SetProperties is not exposed on ReactNativeIsland (#14517) * Add SetAppProperties method to ReactNativeIsland * Change files * rename SetAppProperties to SetProperties * change file * fix * fix * [Fabric] Implement Image body in Image Source RequestImage API (#14568) * Implement body in Image Source * Change files * Add test in playground * [Fabric] Implement zoomScale, maximumZoomScale and minimumZoomScale in ScrollView (#14562) * Implemet maximumZoomScale and minimumZoomScalein ScrollView * Change files * lint fix * Add zoomScale * Implement adjustsFontSizeToFit property for Text in Fabric (#14519) * Implementation of adjustFontSizeToFit * Final Changes using TextLayout * Lint Issue Fixes * Change files * prop change detection added * review Changes and E2E test cases added * Lint and Format Changes added * Test Cases Fix added * Update SnapShot * Removed the additional Check for resizing Font * Updated SnapShot * Review Changes * Lint and Format Changes --------- Co-authored-by: Vineeth K <[email protected]> * [Fabric] Implement scrollEventThrottle for ScrollView (#14555) * Update WindowsAppSDK version to 1.7.250401001 (#14605) * Update WindowsAppSDK version to 1.7.250401001 * Change files * Update nuget lock files * more nuget lock file updates * Bump webview props * updated lock files * Implement accessibilityLevel for Fabric (#14593) * Implement accessibilityLevel for Fabric * Change files * Added Test Cases for the accessibility Label, Level etc. * Updating snapshots --------- Co-authored-by: Vineeth K <[email protected]> * [Fabric] Implement hidesWhenStopped in ActivityIndicator (#14615) * Fix: Text component pressRetentionOffset issue on Windows (#14596) * Fix: Text component pressRetentionOffset issue on Windows * Change files * lint formatting fixed --------- Co-authored-by: Abhijeet Jha <[email protected]> * [Fabric] Implement minimumFontScale in Text (#14617) * Fix InitialProps (#14620) * Fix InitialProps * Change files * [Fabric] Implement the onPressIn property for the fabric implementation of TextInput (#14480) * Implemented OnPressIn event for textinput --------- * Implement OnScrollEndDrag Event Handler for ScrollView (#14473) * Implement onScrollEndDrag prop * Change files * lint fix * Address comments * add noexcept * Address feedback * Fix : Incorrect view access to obtain ContentIsland from for the DesktopPopupSiteBridge (#14628) * solved access read violation due to incorrect view access to obtain contentIsland * rolling back text.tsx * Update end of line text.tsx * rolled back Playground-Composition.vcxproj * rolled back Playground-Composition.vcxproj * fixed lint Playground-Composition.vcxproj * master Playground-Composition.vcxproj * rolled back Playground-Composition.vcxproj * indentation fix Playground-Composition.vcxproj * Revert unintended changes in Playground-Composition.vcxproj * added patch for winUiex[erimental removal * Change files --------- Co-authored-by: Abhijeet Jha <[email protected]> Co-authored-by: Vineeth <[email protected]> * [Fabric] Implement selectTextOnFocus prop in TextInput (#14641) * fix change file type * format * Bump hermes version - enable hermes native microtasks (#14635) * Bump hermes version * Change files * Bump JSI_VERSION to 19 * Opt into microtasks * buidl fix * update playground packages.lock with the script * temp: gather crash dmp * try larger machine * Pickup microsoft/node-api-jsi#13 * Update hermes with uap nuget fix * [Fabric] Implementation of accessibiltyAnnotation and adding support for IAnnotationProvider (#14626) * Implement accessibilityAnnotation for RNW Fabric * AccessibilityAnnotation Prop implementation final changes * Playground Changes * IAnnotationProvider Implementation * Adding CompositionAnnotationProvider to the project * Adding Test Cases * Change files * Lint issue Fixes * Lint fix * Updating SnapShots * Review Changes * Updating snapshot * Properly hook up root uia provider to island (#14643) * Properly hook up root uia provider to island * Change files * Modal : Added Titlebar , title , X handling and movable for windows (#14636) * addded titlebar , title handling , X handling , resizable * Change files * lint and format fix * removed debug logs and resizable property * removed unused imports from modalHostView .cpp file * lint and format fix * Update Modal.windows.js syntax after resolve conflict * updated overrides * updated rctmodalhostview file override structure --------- Co-authored-by: Abhijeet Jha <[email protected]> * [Fabric] Implementation of accessibilityAccessKey and accessibilityItemType (#14658) * {Fabric] Implementation of accessibilityAccessKey and accessibilityItemType * Change Files * Updating snapShot * Implement CallInvoker as replacement for JSDispatcher (#14648) * Remove usage of JSDispatcher in various built-in modules * Change files * format * Implement public JSDispatcher on top of CallInvoker * format * Add ReactContext.CallInvoker and JsiInitializers * format * format * build fix * build fixes * Cleanup * Add runtime handle to instance created and instance loaded events * fix * fix * fix * fix * Remove unused JSDispatcherWriter * Bump folly to 2024.10.14.00 (#14532) * merge in folly 2024.10.14.00 * download fastfloat into node_modules * Change files * fix includes * fix cachelocality * fix desktop.dll * clean paths and fix ARM64EC * add FastFloatCommitHash to folly CGManifest * fix types * revert package.lock and fix json file path * manually fix spacing * fix * feedback * Scale loading bar text when island is super small (#14680) * Scale loading bar text when island is super small * Change files * Fix crash when reloading an instance with an active ReactNativeIsland (#14676) * Fix crash when reloading an instance with an active ReactNativeIsland * Change files * Update simple sample to use function component rather than component class * More cleanup * Fix warnings * Reenable optimization in TMs to avoid going through a dynamic for callbacks/promises (#14691) * Reenable optimization in TMs to avoid going through a dynamic for callbacks/promises * Change files * [Fabric] Implement maxFontSizeMultiplier in Text (#14622) * Clean up error messages (#14695) * Clean up error messages * Change files * JSValue exports data fields - should export value reference accessors (#14707) * JSValue shouldn't export data fields, which make it hard to use MS.RN.Cxx across dll boundaries * Change files * missing functions * fix * Fix unreferenced parameter warning in glog stub (#14708) * Fix warning in glog stub * Change files * Update folly exports from rn-win32 (#14710) * Update folly exports from rn-win32 * Change files * change files * lint fix * lint fix * update override * update snapshots * arm64ec fix * Pointer events (#14713) * PointerEvent fixes * Change files * format * Fix integration test --------- Co-authored-by: JesseCol <[email protected]> Co-authored-by: Tatiana Kapos <[email protected]> Co-authored-by: Hampus Sjöberg <[email protected]> Co-authored-by: Daniel Ayala <[email protected]> Co-authored-by: Anupriya Verma <[email protected]> Co-authored-by: Abhijeet Jha <[email protected]> Co-authored-by: Abhijeet Jha <[email protected]> Co-authored-by: Chiara Mooney <[email protected]> Co-authored-by: Vineeth <[email protected]> Co-authored-by: Vineeth K <[email protected]> Co-authored-by: Harini Malothu <[email protected]> Co-authored-by: Sharath Manchala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Debug Infrastructure
Area: Paper
Old Architecture
Broad category for issues that apply to the RN "old" architecture of Cxx Modules + Paper
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes unnecessary call to Super::DispatchCommand, ViewManagerBase will just assert(false) on dispatch command. https://github.com/microsoft/react-native-windows/blob/main/vnext/Microsoft.ReactNative/Views/ViewManagerBase.cpp#L358. Seemed better just to remove the call incase Meta adds more methods we aren't supporting on Paper.
But let me know if the call is necessary for some reason I'm missing, we could also add a check to ignore the unsupported methods (see previous commit).
Type of Change
Why
react dev-tools will fail because upstream added the methods "highlightTraceUpdates", "highlightElements", and "clearElementsHighlights" and we only added those for Fabric, not Paper.
Resolves #14298
Testing
tested that react devtools works again!
Changelog
yes - Fixes react devtools hitting an assert on launch
Microsoft Reviewers: Open in CodeFlow