Navigation API extracted to the extension #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dryganets, |
dryganets
force-pushed
the
sergeyd/remove-navigator-api
branch
from
fbba079 to
f4b37a8
Compare
StandardDelegate uses react-native-deprecated-components Navigator.
dryganets
force-pushed
the
sergeyd/remove-navigator-api
branch
from
2aaa063 to
c1a762a
Compare
dryganets
force-pushed
the
sergeyd/remove-navigator-api
branch
from
9835b4e to
13032ea
Compare
Closed
…s out that deprecated version of Navigator is not compatible with react-native 0.42.
…h corrected imports. Some samples doesn't work with 1.0.4
berickson1
reviewed
Aug 24, 2017
extensions/navigation/package.json
Outdated
| "typescript": "2.4.1", | ||
| "tslint": "^5.0.0" | ||
| }, | ||
| "author": "Sergei Dryganets", |
There was a problem hiding this comment.
"ReactXP Team [email protected]"
berickson1
requested changes
Aug 24, 2017
| @@ -10,17 +10,24 @@ | |||
| * pop, which update the state and cause transitions. | |||
| */ | |||
|
|
|||
| import _ = require('./utils/lodashMini'); | |||
| import _ = require('lodash'); | |||
There was a problem hiding this comment.
I still think we want lodashmini for best bundled size
| "experimentalDecorators": true, | ||
| "noImplicitAny": true, | ||
| "outDir": "dist/", | ||
| "lib": [ |
There was a problem hiding this comment.
if it's easy, please try enabling strictNullChecks here
There was a problem hiding this comment.
I fixed it for react-native. For the web, it is way more tricky, and I don't have enough context for it now.
extensions/navigation/package.json
Outdated
| ], | ||
| "dependencies": { | ||
| "@types/lodash": "4.14.62", | ||
| "@types/node": "6.0.65", |
There was a problem hiding this comment.
use semver '^' throughout so consumers don't get stuck on a particular version
vinils
suggested changes
Aug 24, 2017
dryganets
force-pushed
the
sergeyd/remove-navigator-api
branch
from
d3f465f to
ff48fce
Compare
dryganets
force-pushed
the
sergeyd/remove-navigator-api
branch
from
ff48fce to
74670f1
Compare
|
@vinils, thank you fixed hello-world and removed the last reference from todo list. |
dryganets
changed the title
berickson1
reviewed
Aug 24, 2017
| @@ -0,0 +1,143 @@ | |||
| // Use only for type data | |||
There was a problem hiding this comment.
Missing copyright header
berickson1
reviewed
Aug 24, 2017
|
|
||
| type NavigationSceneRendererProps = Navigation.NavigationSceneRendererProps; | ||
| type NavigationState = Navigation.NavigationState; | ||
| type NavigationRoute = Navigation.NavigationRoute; | ||
| type NavigationTransitionProps = Navigation.NavigationTransitionProps; | ||
|
|
||
berickson1
reviewed
Aug 24, 2017
| import React = require('react'); | ||
| import ReactDOM = require('react-dom'); | ||
| import rebound = require('rebound'); | ||
|
|
||
| import { NavigatorSceneConfigFactory } from './NavigatorSceneConfigFactory'; | ||
| import { NavigatorSceneConfig } from './NavigatorSceneConfigFactory'; | ||
| import RX = require('../common/Interfaces'); | ||
| import Styles from './Styles'; | ||
| import RX = require('reactxp'); |
There was a problem hiding this comment.
nit: these should go up with other ambient imports
berickson1
approved these changes
Aug 24, 2017
dryganets
force-pushed
the
sergeyd/remove-navigator-api
branch
from
acb15f0 to
cea94ad
Compare
berickson1
pushed a commit
to berickson1/reactxp
that referenced
this pull request
Oct 22, 2018
* Removed Navigation API from reactxp and moved to extension * Updated samples with reactxp-navigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Navigator API with extension.
We moved to react-native-deprecated-custom-components for StandardNavigationDelegate and to reactxp-experimental-navigation for ExperimentalNavigationDelegate.
There is a breaking change in the standard navigator. Styles should be passed as objects to the renderScene method.
facebook/react-native@febf3d0