Fixing package.json dependencies #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chuwik, It will cover your contributions to all Microsoft-managed open source projects. |
Closed
deregtd
pushed a commit
that referenced
this pull request
Sep 18, 2017
deregtd
added a commit
that referenced
this pull request
Sep 19, 2017
…nitions (#280) * Rename #1 for ViewBase to fix caps * Rename #2 to fix ViewBase. Enabling forceConsistentCasingInFileNames. * Enabling noImplicitReturns, fixing a bug in native-common/Linking.ts * Enabling noImplicitThis * Enabling noUnusedLocals and fixing some bugs it found * Enabling strict null checks on reactxp * Addressing PR feedback * Fixing a bunch of type exporting/checking issues * Fixed a bunch of base interfaces and made everything inherit from them. Made the exported reactxp.ts files per-platform export types from the base classes instead of their specific implementation. This brought a bunch of interface holes to the surface.
Closed
Closed
berickson1
pushed a commit
to berickson1/reactxp
that referenced
this pull request
Oct 22, 2018
…nitions (microsoft#280) * Rename microsoft#1 for ViewBase to fix caps * Rename microsoft#2 to fix ViewBase. Enabling forceConsistentCasingInFileNames. * Enabling noImplicitReturns, fixing a bug in native-common/Linking.ts * Enabling noImplicitThis * Enabling noUnusedLocals and fixing some bugs it found * Enabling strict null checks on reactxp * Addressing PR feedback * Fixing a bunch of type exporting/checking issues * Fixed a bunch of base interfaces and made everything inherit from them. Made the exported reactxp.ts files per-platform export types from the base classes instead of their specific implementation. This brought a bunch of interface holes to the surface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-native and react-native-windows were specified as devDependencies, but they are actually required at runtime not just to build reactxp. This was causing an issue also in the sample app, since
npm run startwouldn't work because react-native wouldn't exist in node_modules. An alternative is to specify react-native and react-native-windows as peerDependencies, if we want users to be able to choose a range, and include them as dependencies in the sample app. But if we want to lock down what versions they use, having a direct dependency is probably fine.Also the sample app had a bunch of packages in its dependencies section which didn't need to, since they're already direct dependencies of reactxp and so they're already pulled on
npm install