Fix DynamicModuleLoader and remove support for React-Redux 5 #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet-g
reviewed
Apr 13, 2019
| if (this.props.reactReduxContext !== this._memoizedRRContext) { | ||
| this._memoizedRRContext = { | ||
| ...this.props.reactReduxContext, | ||
| storeState: this.props.reactReduxContext.store.getState(), |
There was a problem hiding this comment.
Why are we memoizing state only when context changes?
There was a problem hiding this comment.
If the state changes above, then we will get a new context object here.
this.setState({...}) returns a new object
packages/redux-dynamic-modules-react/src/DynamicModuleLoader.tsx
Outdated
Show resolved
Hide resolved
|
Please add some unit tests ... did you test all the examples with these changes? |
navneet-g
reviewed
Apr 29, 2019
|
|
||
| createStore?: () => IModuleStore<any>; | ||
| interface IDynamicModuleLoaderImplProps extends IDynamicModuleLoaderProps { | ||
| reactReduxContext?: { store: IModuleStore<any> }; |
| throw new Error( | ||
| "Store could not be resolved from React context" | ||
| public render(): React.ReactNode { | ||
| if (this.state.readyToRender) { |
There was a problem hiding this comment.
What comments are you looking for here? This seems pretty self explanatory to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
ReactReduxContext, so do that here.createStoreprop, we were not providing a modified context to the first connected component. Now, if we callcreateStoreand render aProvider, we will render another instance ofDynamicModuleLoader, which will actually add the modules.react-redux@5This should result in a major version bump to V4