[rush] Implement support for selecting a subset of dependencies to deploy #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

octogonz merged 7 commits into microsoft:master from willsoto:feat/1978

Jul 14, 2020

Contributor

willsoto commented Jul 11, 2020 •

edited

Loading

Add new settings to template
Document new settings in deploy-scenario.schema.json
Implement dependenciesToExclude
Implement additionalDependenciesToInclude

Closes #1978

willsoto changed the title ~~Implement support for selecting a subset of dependencies to deploy~~ [rush] Implement support for selecting a subset of dependencies to deploy

willsoto marked this pull request as ready for review

July 13, 2020 14:39

willsoto requested review from apostolisms, D4N14L, halfnibble, iclanton, octogonz and sachinjoseph as code owners

July 13, 2020 14:39

Contributor Author

willsoto commented Jul 13, 2020 •

edited

Loading

@octogonz Here is a first pass at this. I've added some comments to facilitate discussion

willsoto commented

View reviewed changes

apps/rush-lib/src/logic/deploy/DeployManager.ts Show resolved Hide resolved

willsoto commented

View reviewed changes

apps/rush-lib/src/logic/deploy/DeployManager.ts Outdated Show resolved Hide resolved

willsoto commented

View reviewed changes

apps/rush-lib/src/logic/deploy/DeployManager.ts Outdated Show resolved Hide resolved

willsoto commented

View reviewed changes

apps/rush-lib/src/logic/deploy/DeployManager.ts Show resolved Hide resolved

willsoto commented

View reviewed changes

apps/rush-lib/src/logic/deploy/Utils.ts Show resolved Hide resolved

willsoto commented

View reviewed changes

apps/rush-lib/src/logic/deploy/DeployManager.ts Outdated Show resolved Hide resolved

willsoto added 2 commits

July 13, 2020 10:54


          Give rush deploy the ability to select a subset of dependencies to co…

46d6e4a

…py over

Closes #1978

Signed-off-by: Will Soto <[email protected]>


          Rush change

290093a

Signed-off-by: Will <[email protected]>

willsoto commented

View reviewed changes

apps/rush-lib/src/logic/deploy/DeployManager.ts Outdated Show resolved Hide resolved

octogonz added 5 commits

July 13, 2020 18:16


          Merge remote-tracking branch 'remotes/origin/master' into feat/1978

f1e1718


          Rename allDependencyNames to dependencyNamesToProcess

6e12406


          Simplify expression

fbcd2a2


          Sneak in an unrelated change since we're about to publish Rush

d4a93c2


          Tune up logging so that _applyDependencyFilters() doesn't print outpu…

f2de8d3

…t unless something is actually added/removed

octogonz approved these changes

View reviewed changes

octogonz merged commit 9dca6bc into microsoft:master

Collaborator

octogonz commented Jul 14, 2020

This was released with Rush 5.29.0

willsoto deleted the feat/1978 branch

July 14, 2020 11:56

Contributor Author

willsoto commented Jul 14, 2020

@octogonz thanks for the review and quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

octogonz octogonz approved these changes

apostolisms Awaiting requested review from apostolisms

D4N14L Awaiting requested review from D4N14L

halfnibble Awaiting requested review from halfnibble

iclanton Awaiting requested review from iclanton

sachinjoseph Awaiting requested review from sachinjoseph

Labels

None yet