More type checking #398
More type checking #398
Conversation
|
|
||
| func (c *Checker) checkJSDocComment(node *ast.Node, location *ast.Node) { | ||
| switch node.Kind { | ||
| case ast.KindJSDocLink, ast.KindJSDocLinkCode, ast.KindJSDocLinkPlain: |
There was a problem hiding this comment.
Agh, missed that this doesn't check @see, so won't catch everything.
There was a problem hiding this comment.
@see is a tag, so it is indeed checked (to link to a symbol in a @see tag you actually have to write @see {@link Foo}).
There was a problem hiding this comment.
@see variable is valid without any @link: microsoft/TypeScript#35524
https://www.typescriptlang.org/play/?ts=4.1.0-beta#example/see-in-jsdoc
There was a problem hiding this comment.
Right, but the old compiler doesn't actually mark Foo as referenced because of an @see Foo tag. Maybe it should, but neither the old nor the new compiler has logic for that right now.
I went to retest vscode and got a couple of errors still; maybe just that my version is newer? (Or older?) |
In this PR:
@linkdirectives for unused identifier checks).With this PR, the VS Code project now compiles with no errors or warnings (and the fact that no unused identifiers are reported is indication that everything is being checked). Beyond JSDoc and JSX, very little remains to be ported in the type checker and performance should now be representative of what we'll see in the completed port.