Skip to content

Remove node.js programming model experimental flag #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Remove node.js programming model experimental flag #3612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ff2eab
Remove node.js programming model experimental flag
nturinski Mar 3, 2023
7fedf9d
Fix merge
nturinski Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Change Log

## 1.10.3 - 2023-03-07

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything needed here yet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning to write it up, but wanted to first see if anyone knew if Alex had a script to pull in all the PRs into the changelog.


## 1.10.2 - 2023-02-23

### Added
Expand Down
5 changes: 0 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,11 +1079,6 @@
"type": "string",
"default": "src/functions",
"description": "%azureFunctions.functionSubpath%"
},
"azureFunctions.showNodeProgrammingModel": {
"type": "boolean",
"description": "%azureFunctions.showNodeProgrammingModel%",
"default": false
}
}
}
Expand Down
2 changes: 0 additions & 2 deletions package.nls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,7 @@
"azureFunctions.showExtensionsCsprojWarning": "Show a warning when an Azure Functions project was detected that has mismatched \"extensions.csproj\" configuration.",
"azureFunctions.showHiddenStacks": "Show hidden runtime stacks when creating a Function App in Azure. WARNING: These stacks may be in preview or may not be available in all regions.",
"azureFunctions.showMultiCoreToolsWarning": "Show a warning if multiple installs of Azure Functions Core Tools are detected.",
"azureFunctions.showNodeProgrammingModel": "Enable preview Node.js programming model",
"azureFunctions.showProjectWarning": "Show a warning when an Azure Functions project was detected that has not been initialized for use in VS Code.",
"azureFunctions.showPysteinModel": "Enable Python (New Model Preview)",
"azureFunctions.showPythonVenvWarning": "Show a warning when an Azure Functions Python project was detected that does not have a virtual environment.",
"azureFunctions.showReloadTemplates": "Show an option to reload templates when creating a function. This will clear the template cache.",
"azureFunctions.showTargetFrameworkWarning": "Show a warning when an Azure Functions .NET project was detected that has mismatched target frameworks.",
Expand Down
5 changes: 1 addition & 4 deletions src/commands/createNewProject/ProgrammingModelStep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
*--------------------------------------------------------------------------------------------*/

import { AzureWizardPromptStep, IAzureQuickPickItem, IAzureQuickPickOptions, nonNullValue, openUrl } from '@microsoft/vscode-azext-utils';
import { nodeProgrammingModelSetting } from '../../constants';
import { localize } from '../../localize';
import { getWorkspaceSetting } from '../../vsCodeConfig/settings';
import { IProjectWizardContext } from './IProjectWizardContext';

type ProgrammingModel = { modelVersion: number | undefined, label: string };
Expand Down Expand Up @@ -60,7 +58,6 @@ export class ProgrammingModelStep extends AzureWizardPromptStep<IProjectWizardCo

// this only impacts node for now so only check the feature flag for node
return context.languageModel === undefined &&
(!!getWorkspaceSetting(nodeProgrammingModelSetting) &&
(context.language === 'JavaScript' || context.language === 'TypeScript'));
(context.language === 'JavaScript' || context.language === 'TypeScript');
}
}
1 change: 0 additions & 1 deletion src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export const projectTemplateKeySetting: string = 'projectTemplateKey';
export const remoteBuildSetting: string = 'scmDoBuildDuringDeployment';
export const javaBuildTool: string = 'javaBuildTool';
export const functionSubpathSetting: string = 'functionSubpath';
export const nodeProgrammingModelSetting: string = 'showNodeProgrammingModel';

export enum ProjectLanguage {
CSharp = 'C#',
Expand Down