This repository was archived by the owner on Nov 30, 2023. It is now read-only.
update install.sh #1057
Merged
update install.sh #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the Dockerfile need to get updated too for the copy statement? |
|
This dockerfile won't be used anymore, I now keep it here: |
|
I suppose for clarity, i'll delete that Dockerfile |
|
Can we still regression test? The Dockerfile in this repo was there to allow us to run a test.sh to verify the script is working as things change. We can wire that into CI. Using the test script and test.sh right now. |
|
ah yes, will fix that up. |
|
Added new CI job to run that test.sh |
|
LGTM!! Merge when ready! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to work with https://github.com/microsoft/vscode-remote-containers/pull/153