Enable intellisense and improve web smoke tests #9623
Conversation
| "debugWebWorkerHost": true, | ||
| "request": "launch", | ||
| "args": [ | ||
| "--extensionDevelopmentPath=${workspaceFolder}", |
There was a problem hiding this comment.
Currently this doesn't work because of node-fetch.
We can use cross-fetch (via webpack) to get around this, however i think its a bug caused by vscode.
node-fetch works in tests when run from the CLI, however when you debug it fails, something to do with global variables (in webworker, self is available, but when debugging self is not available, could be something vscode is shadowing or removing deliberately).
There was a problem hiding this comment.
I.e. a bug in vscode.
|
|
||
| const path = require('path'); | ||
| const test_web = require('@vscode/test-web'); | ||
| async function go() { |
There was a problem hiding this comment.
With this, we don't need to compile the ts file anymore, we can just run webpack and that's it.
There was a problem hiding this comment.
Besides TS is smart enough to give decent completions for this.
| }; | ||
|
|
||
| // When running web tests, the entry point for the tests and extension are the same. | ||
| const entry = process.env.VSC_TEST_BUNDLE ? testEntry : prodEntry; |
There was a problem hiding this comment.
This is where the magic happens
| entry: { | ||
| extension: './src/extension.web.ts', | ||
| 'test/vscode.test/index': './src/test/web/vscode.test/index.ts', // source of the web extension test runner | ||
| 'test/smoke.test/index': './src/test/web/smoke.test/index.ts' // source of the web extension test runner |
There was a problem hiding this comment.
test/vscode.test/index was never used.
There was a problem hiding this comment.
Well not yet. I was going to use it to host the vscode tests.
There was a problem hiding this comment.
what's a vscode test?
| @@ -102,14 +101,6 @@ export function buildApi( | |||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | |||
| (api as any).serviceContainer = serviceContainer; | |||
| (api as any).serviceManager = serviceManager; | |||
| (api as any).getSymbol = (symbol: String) => { | |||
| // bundles all files in the current directory matching `*.test` | ||
| const importAll = (r: __WebpackModuleApi.RequireContext) => r.keys().forEach(r); | ||
| importAll(require.context('.', true, /\.web.test$/)); | ||
| // Basically this is the entry point for the extension. |
There was a problem hiding this comment.
This bundle will be the entry point for the extension, and everything uses the same bundle and tests are in here too.
| const appShellSymbol = extensionApi.getSymbol<IApplicationShell>('IApplicationShell'); | ||
| assert.ok(appShellSymbol, `Cannot get the symbol for IApplicationShell`); | ||
| const appShell = extensionApi.serviceManager?.get<IApplicationShell>(appShellSymbol!); | ||
| const appShell = extensionApi.serviceManager?.get<IApplicationShell>(IApplicationShell); |
There was a problem hiding this comment.
Note; Previously we didn't get any intellisense in here at all, now we do.
This was because of an entry in tsconfig.json, now we get full code completion in these files.
| @@ -22,7 +22,7 @@ | |||
| "resolveJsonModule": true, | |||
| "removeComments": true, | |||
| "useUnknownInCatchVariables": false, | |||
| "types": ["@types/vscode-notebook-renderer/preload"] | |||
| "types": ["@types/vscode-notebook-renderer/preload", "webpack-env"] | |||
There was a problem hiding this comment.
For better development experience (i.e. during editing we'll get code completions)
| @@ -35,7 +35,6 @@ | |||
| "src/ipywidgets", | |||
| "src/smoke", | |||
| "src/test/datascience/extensionapi", | |||
| "src/test/web", | |||
There was a problem hiding this comment.
For better development experience (i.e. during editing we'll get code completions)
Codecov Report
@@ Coverage Diff @@
## main #9623 +/- ##
====================================
Coverage 72% 72%
====================================
Files 193 194 +1
Lines 8451 8421 -30
Branches 1238 1229 -9
====================================
- Hits 6136 6121 -15
+ Misses 1851 1829 -22
- Partials 464 471 +7
|
No description provided.